Convert //third_party from scoped_ptr to std::unique_ptr

Convert //third_party from scoped_ptr to std::unique_ptr

BUG=554298
Committed: https://crrev.com/91cdd51340b8f6a0cc13ec9f5199defbea6cd49c
Cr-Commit-Position: refs/heads/master@{#389307}

[dcheng, 2016-04-21 19:25:28]

dcheng@chromium.org changed reviewers:
+ andrewhayden@chromium.org, estade@chromium.org, gavinp@chromium.org,
jsbell@chromium.org, mark@chromium.org, rsesek@chromium.org, zea@chromium.org

[dcheng, 2016-04-21 19:28:07]

+zea for //third_party/cacheinvalidation
+andrewhayden for //third_party/cld
+rsesek for //third_party/crashpad
+jsbell for //third_party/leveldatabase
+estade for //third_party/libaddressinput
+mark for //third_party/sudden_motion_sensor
+gavinp for //third_party/zlib

https://codereview.chromium.org/1911823002/diff/20001/third_party/cld/base/sc...
File third_party/cld/base/scoped_ptr.h (left):

https://codereview.chromium.org/1911823002/diff/20001/third_party/cld/base/sc...
third_party/cld/base/scoped_ptr.h:1: // Copyright (c) 2006-2009 The Chromium
Authors. All rights reserved.
Appears to be unused, so I deleted it. My local build still seems to work?

[Andrew Hayden (chromium.org), 2016-04-21 19:31:52]

third_party/cld LGTM. FWIW, CLD1 (third_party/cld) is completely dead (as you
seem to have noticed!) and I'm planning to prune it in the very near future, so
this is a no-op for CLD (we use third_party/cld_2 on all platforms).

[Robert Sesek, 2016-04-21 19:45:31]

third_party/crashpad LGTM

https://codereview.chromium.org/1911823002/diff/20001/third_party/crashpad/cr...
File third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc (left):

https://codereview.chromium.org/1911823002/diff/20001/third_party/crashpad/cr...
third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc:15: #include
"snapshot/win/process_snapshot_win.h"
Don't think this is right.

[dcheng, 2016-04-21 20:11:00]

https://codereview.chromium.org/1911823002/diff/20001/third_party/crashpad/cr...
File third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc (left):

https://codereview.chromium.org/1911823002/diff/20001/third_party/crashpad/cr...
third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc:15: #include
"snapshot/win/process_snapshot_win.h"
On 2016/04/21 at 19:45:30, Robert Sesek wrote:
> Don't think this is right.

Done.

[Mark Mentovai, 2016-04-21 20:30:21]

https://codereview.chromium.org/1911823002/diff/40001/third_party/crashpad/cr...
File third_party/crashpad/crashpad/client/crash_report_database.h (right):

https://codereview.chromium.org/1911823002/diff/40001/third_party/crashpad/cr...
third_party/crashpad/crashpad/client/crash_report_database.h:1: // Copyright
2015 The Crashpad Authors. All rights reserved.
I’d expect to see something in README.chromium about this change at least in
Crashpad’s file. Probably in others, too.

(You asked me to review sudden_motion_sensor, and its README.chromium’s “Local
Modifications” is already broad enough to cover this change. But I don’t think
that’s going to be the case everywhere.)

[dcheng, 2016-04-21 20:39:40]

On 2016/04/21 at 20:30:21, mark wrote:
>
https://codereview.chromium.org/1911823002/diff/40001/third_party/crashpad/cr...
> File third_party/crashpad/crashpad/client/crash_report_database.h (right):
> 
>
https://codereview.chromium.org/1911823002/diff/40001/third_party/crashpad/cr...
> third_party/crashpad/crashpad/client/crash_report_database.h:1: // Copyright
2015 The Crashpad Authors. All rights reserved.
> I’d expect to see something in README.chromium about this change at least in
Crashpad’s file. Probably in others, too.
> 
> (You asked me to review sudden_motion_sensor, and its README.chromium’s “Local
Modifications” is already broad enough to cover this change. But I don’t think
that’s going to be the case everywhere.)

Done. That being said, it's hard for me to tell what requires README.chromium
updates and what doesn't. For example, the cacheinvalidation repository exists
only in Chromium at this point, so it probably doesn't make sense to update that
to mention this local change. Other changes (libaddressinput, leveldatabase,
zlib) look specific to wrappers to help Chromium interact with the code and
wouldn't exist upstream anyway, so updating README.chromium in those places also
doesn't feel very meaningful.

[Nicolas Zea, 2016-04-21 20:43:42]

cacheinvalidation LGTM

[Mark Mentovai, 2016-04-21 20:49:31]

LGTM in crashpad and sudden_motion_sensor.

If something’s upstream has gone away and we maintain the authoritative copy in
Chromium, but we’re keeping it in third_party to make ownership and licensing
clear, then its README.chromium should say that. If it does, “local
modifications” is meaningless, so it’s OK to not update.

In other cases where we’ve added wrappers or rewritten things to match our
style, README.chromium should say that, and this work probably falls under the
existing modifications, so it’s OK to not update.

But in the (probably most common) case where we’ve done a pristine import and
maybe made a few small local tweaks (or maybe zero small local tweaks), we’re
already very close to the upstream, and README.chromium should be updated. This
will make it easier for the next person who winds up syncing our copy with the
upstream.

[gavinp, 2016-04-22 14:42:57]

third_party/zlib lgtm.

[jsbell, 2016-04-22 16:43:12]

leveldatabase lgtm

[please use gerrit instead, 2016-04-22 19:34:32]

rouslan@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2016-04-22 19:34:33]

//third_party/libaddressinput lgtm

[dcheng, 2016-04-22 19:34:58]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-22 19:34:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
andrewhayden@chromium.org, rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1911823002/#ps60001
(title: "Update crashpad's README.chromium")

[commit-bot: I haz the power, 2016-04-22 19:35:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911823002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911823002/60001

[commit-bot: I haz the power, 2016-04-22 23:49:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 23:50:16]

Description was changed from

==========
Convert //third_party from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //third_party from scoped_ptr to std::unique_ptr

BUG=554298

Committed: https://crrev.com/91cdd51340b8f6a0cc13ec9f5199defbea6cd49c
Cr-Commit-Position: refs/heads/master@{#389307}
==========

[commit-bot: I haz the power, 2016-04-22 23:50:17]

Patchset 4 (id:??) landed as
https://crrev.com/91cdd51340b8f6a0cc13ec9f5199defbea6cd49c
Cr-Commit-Position: refs/heads/master@{#389307}