third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc ('k') | third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h

diff --git a/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h b/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h

index 4d33d7be2e6bba8fb0f474d18cf2c35e5b271559..2f7f9cbad848a67a33a3a4abe4517a3eb0338e74 100644

--- a/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h

+++ b/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.h

@@ -20,11 +20,11 @@

#include <sys/types.h>

#include <map>

+#include <memory>

#include <string>

#include <vector>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "client/crashpad_info.h"

#include "snapshot/crashpad_info_client_options.h"

#include "snapshot/exception_snapshot.h"

@@ -188,7 +188,7 @@ class ProcessSnapshotWin final : public ProcessSnapshot {

PointerVector<internal::ThreadSnapshotWin> threads_;

PointerVector<internal::ModuleSnapshotWin> modules_;

std::vector<UnloadedModuleSnapshot> unloaded_modules_;

- scoped_ptr<internal::ExceptionSnapshotWin> exception_;

+ std::unique_ptr<internal::ExceptionSnapshotWin> exception_;

PointerVector<internal::MemoryMapRegionSnapshotWin> memory_map_;

ProcessReaderWin process_reader_;

UUID report_id_;