third_party/crashpad/crashpad/snapshot/mac/process_reader.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/mac/process_reader.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/mac/process_reader.h ('k') | third_party/crashpad/crashpad/snapshot/mac/process_snapshot_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/mac/process_reader.cc

diff --git a/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc b/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc

index c7f674bbc97af0346448a2992c6725d0333a9a5b..3b11eb1d788d5e81982b41cd00bb1747308d3429 100644

--- a/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc

+++ b/third_party/crashpad/crashpad/snapshot/mac/process_reader.cc

@@ -429,7 +429,7 @@ void ProcessReader::InitializeModules() {

// Proceed anyway with an empty module name.

}

- scoped_ptr<MachOImageReader> reader(new MachOImageReader());

+ std::unique_ptr<MachOImageReader> reader(new MachOImageReader());

if (!reader->Initialize(this, image_info.imageLoadAddress, module.name)) {

reader.reset();

}

@@ -510,7 +510,7 @@ void ProcessReader::InitializeModules() {

}

std::string module_name = !module.name.empty() ? module.name : "(dyld)";

- scoped_ptr<MachOImageReader> reader(new MachOImageReader());

+ std::unique_ptr<MachOImageReader> reader(new MachOImageReader());

if (!reader->Initialize(

this, all_image_infos.dyldImageLoadAddress, module_name)) {

reader.reset();