Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc
diff --git a/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc b/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc
index a5b83ac4025efa187f619f4658a70c38109ab1be..1bf3c017b0800d7a3cdd5011e75c3dc162acb555 100644
--- a/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc
+++ b/third_party/crashpad/crashpad/minidump/minidump_simple_string_dictionary_writer_test.cc
@@ -12,16 +12,16 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "minidump/minidump_simple_string_dictionary_writer.h"
-
#include <stdint.h>
#include <map>
#include <string>
#include <utility>
+#include "base/memory/ptr_util.h"
#include "gtest/gtest.h"
#include "minidump/minidump_extensions.h"
+#include "minidump/minidump_simple_string_dictionary_writer.h"
#include "minidump/test/minidump_string_writer_test_util.h"
#include "minidump/test/minidump_writable_test_util.h"
#include "util/file/string_file.h"
@@ -64,7 +64,7 @@ TEST(MinidumpSimpleStringDictionaryWriter, EmptyKeyValue) {
MinidumpSimpleStringDictionaryWriter dictionary_writer;
auto entry_writer =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
dictionary_writer.AddEntry(std::move(entry_writer));
EXPECT_TRUE(dictionary_writer.IsUseful());
@@ -97,7 +97,7 @@ TEST(MinidumpSimpleStringDictionaryWriter, OneKeyValue) {
MinidumpSimpleStringDictionaryWriter dictionary_writer;
auto entry_writer =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
entry_writer->SetKeyValue(kKey, kValue);
dictionary_writer.AddEntry(std::move(entry_writer));
@@ -135,15 +135,15 @@ TEST(MinidumpSimpleStringDictionaryWriter, ThreeKeysValues) {
MinidumpSimpleStringDictionaryWriter dictionary_writer;
auto entry_writer_0 =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
entry_writer_0->SetKeyValue(kKey0, kValue0);
dictionary_writer.AddEntry(std::move(entry_writer_0));
auto entry_writer_1 =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
entry_writer_1->SetKeyValue(kKey1, kValue1);
dictionary_writer.AddEntry(std::move(entry_writer_1));
auto entry_writer_2 =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
entry_writer_2->SetKeyValue(kKey2, kValue2);
dictionary_writer.AddEntry(std::move(entry_writer_2));
@@ -203,11 +203,11 @@ TEST(MinidumpSimpleStringDictionaryWriter, DuplicateKeyValue) {
MinidumpSimpleStringDictionaryWriter dictionary_writer;
auto entry_writer_0 =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
entry_writer_0->SetKeyValue(kKey, kValue0);
dictionary_writer.AddEntry(std::move(entry_writer_0));
auto entry_writer_1 =
- make_scoped_ptr(new MinidumpSimpleStringDictionaryEntryWriter());
+ base::WrapUnique(new MinidumpSimpleStringDictionaryEntryWriter());
entry_writer_1->SetKeyValue(kKey, kValue1);
dictionary_writer.AddEntry(std::move(entry_writer_1));

Powered by Google App Engine
This is Rietveld 408576698