third_party/crashpad/crashpad/client/crashpad_client_mac.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/client/crashpad_client_mac.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/client/crash_report_database_win.cc ('k') | third_party/crashpad/crashpad/client/crashpad_client_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/client/crashpad_client_mac.cc

diff --git a/third_party/crashpad/crashpad/client/crashpad_client_mac.cc b/third_party/crashpad/crashpad/client/crashpad_client_mac.cc

index 87b01b87a2f1b68f943d75fc75ac5f962c73221e..89a2e275832f8b1066b6ac48e9f04468d4a7d8f9 100644

--- a/third_party/crashpad/crashpad/client/crashpad_client_mac.cc

+++ b/third_party/crashpad/crashpad/client/crashpad_client_mac.cc

@@ -21,11 +21,11 @@

#include <sys/wait.h>

#include <unistd.h>

+#include <memory>

#include <utility>

#include "base/logging.h"

#include "base/mac/mach_logging.h"

-#include "base/memory/scoped_ptr.h"

#include "base/posix/eintr_wrapper.h"

#include "base/strings/stringprintf.h"

#include "util/mac/mac_util.h"

@@ -147,7 +147,7 @@ class HandlerStarter final : public NotifyServer::DefaultInterface {

DCHECK_EQ(right_type,

implicit_cast<mach_msg_type_name_t>(MACH_MSG_TYPE_PORT_SEND));

- scoped_ptr<HandlerStarter> handler_restarter;

+ std::unique_ptr<HandlerStarter> handler_restarter;

if (restartable) {

handler_restarter.reset(new HandlerStarter());

if (!handler_restarter->notify_port_.is_valid()) {