third_party/crashpad/crashpad/util/win/module_version.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/util/win/module_version.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/util/win/exception_handler_server_test.cc ('k') | third_party/crashpad/crashpad/util/win/process_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/util/win/module_version.cc

diff --git a/third_party/crashpad/crashpad/util/win/module_version.cc b/third_party/crashpad/crashpad/util/win/module_version.cc

index 62f9e4246bea481aadad9eab31c4d24911bf736f..bd835380f0e9252dacaf3aa5e0da8959706b7714 100644

--- a/third_party/crashpad/crashpad/util/win/module_version.cc

+++ b/third_party/crashpad/crashpad/util/win/module_version.cc

@@ -17,8 +17,9 @@

#include <windows.h>

#include <stdint.h>

+#include <memory>

#include "base/logging.h"

-#include "base/memory/scoped_ptr.h"

#include "base/strings/utf_string_conversions.h"

namespace crashpad {

@@ -32,7 +33,7 @@ bool GetModuleVersionAndType(const base::FilePath& path,

return false;

}

- scoped_ptr<uint8_t[]> data(new uint8_t[size]);

+ std::unique_ptr<uint8_t[]> data(new uint8_t[size]);

if (!GetFileVersionInfo(path.value().c_str(), 0, size, data.get())) {

PLOG(WARNING) << "GetFileVersionInfo: "

<< base::UTF16ToUTF8(path.value());