third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/win/pe_image_reader.cc ('k') | third_party/crashpad/crashpad/snapshot/win/process_reader_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc

diff --git a/third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc b/third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc

index 3a754a9757596a63aa4153b8b6f8914e3db34511..a010276ab02b523a458944d86a0f31543ef85262 100644

--- a/third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc

+++ b/third_party/crashpad/crashpad/snapshot/win/pe_image_resource_reader.cc

@@ -15,9 +15,9 @@

#include "snapshot/win/pe_image_resource_reader.h"

#include <algorithm>

+#include <memory>

#include "base/logging.h"

-#include "base/memory/scoped_ptr.h"

namespace {

@@ -227,7 +227,7 @@ bool PEImageResourceReader::ReadResourceDirectory(

// resource_directory is optional, but it’s still needed locally even if the

// caller isn’t interested in it.

- scoped_ptr<IMAGE_RESOURCE_DIRECTORY> local_resource_directory;

+ std::unique_ptr<IMAGE_RESOURCE_DIRECTORY> local_resource_directory;

if (!resource_directory) {

local_resource_directory.reset(new IMAGE_RESOURCE_DIRECTORY);

resource_directory = local_resource_directory.get();