third_party/crashpad/crashpad/handler/handler_main.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/handler/handler_main.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/handler/crash_report_upload_thread.cc ('k') | third_party/crashpad/crashpad/handler/prune_crash_reports_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/handler/handler_main.cc

diff --git a/third_party/crashpad/crashpad/handler/handler_main.cc b/third_party/crashpad/crashpad/handler/handler_main.cc

index e022dace31b3355a2823e5532b287a844c62548f..3240cd38b37d79d6c915560aa41f325702cf00cd 100644

--- a/third_party/crashpad/crashpad/handler/handler_main.cc

+++ b/third_party/crashpad/crashpad/handler/handler_main.cc

@@ -19,6 +19,7 @@

#include <stdlib.h>

#include <map>

+#include <memory>

#include <string>

#include <utility>

@@ -26,7 +27,6 @@

#include "base/files/file_path.h"

#include "base/files/scoped_file.h"

#include "base/logging.h"

-#include "base/memory/scoped_ptr.h"

#include "base/scoped_generic.h"

#include "base/strings/utf_string_conversions.h"

#include "build/build_config.h"

@@ -386,7 +386,7 @@ int HandlerMain(int argc, char* argv[]) {

}

#endif // OS_MACOSX

- scoped_ptr<CrashReportDatabase> database(CrashReportDatabase::Initialize(

+ std::unique_ptr<CrashReportDatabase> database(CrashReportDatabase::Initialize(

base::FilePath(ToolSupport::CommandLineArgumentToFilePathStringType(

options.database))));

if (!database) {