third_party/crashpad/crashpad/test/win/win_child_process_test.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/test/win/win_child_process_test.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/test/win/win_child_process.cc ('k') | third_party/crashpad/crashpad/test/win/win_multiprocess.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/test/win/win_child_process_test.cc

diff --git a/third_party/crashpad/crashpad/test/win/win_child_process_test.cc b/third_party/crashpad/crashpad/test/win/win_child_process_test.cc

index 752753530d99bd839752585320bae671af138468..e464c7c047a8cb2ae854676d89a18079a6c60819 100644

--- a/third_party/crashpad/crashpad/test/win/win_child_process_test.cc

+++ b/third_party/crashpad/crashpad/test/win/win_child_process_test.cc

@@ -59,7 +59,7 @@ class TestWinChildProcess final : public WinChildProcess {

TEST(WinChildProcessTest, WinChildProcess) {

WinChildProcess::EntryPoint<TestWinChildProcess>();

- scoped_ptr<WinChildProcess::Handles> handles = WinChildProcess::Launch();

+ std::unique_ptr<WinChildProcess::Handles> handles = WinChildProcess::Launch();

WriteInt(handles->write.get(), 1);

ASSERT_EQ(1, ReadInt(handles->read.get()));

}

@@ -67,9 +67,12 @@ TEST(WinChildProcessTest, WinChildProcess) {

TEST(WinChildProcessTest, MultipleChildren) {

WinChildProcess::EntryPoint<TestWinChildProcess>();

- scoped_ptr<WinChildProcess::Handles> handles_1 = WinChildProcess::Launch();

- scoped_ptr<WinChildProcess::Handles> handles_2 = WinChildProcess::Launch();

- scoped_ptr<WinChildProcess::Handles> handles_3 = WinChildProcess::Launch();

+ std::unique_ptr<WinChildProcess::Handles> handles_1 =

+ WinChildProcess::Launch();

+ std::unique_ptr<WinChildProcess::Handles> handles_2 =

+ WinChildProcess::Launch();

+ std::unique_ptr<WinChildProcess::Handles> handles_3 =

+ WinChildProcess::Launch();

WriteInt(handles_1->write.get(), 1);

WriteInt(handles_2->write.get(), 2);