third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/snapshot/mac/mach_o_image_reader.h ('k') | third_party/crashpad/crashpad/snapshot/mac/memory_snapshot_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc

diff --git a/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc b/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc

index 49655b69e6402e37cf3e9ed0f87bb482cf3a2521..c5eb196929d45da5eed76b0c3a3e9183a38aaf9f 100644

--- a/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc

+++ b/third_party/crashpad/crashpad/snapshot/mac/mach_o_image_symbol_table_reader.cc

@@ -18,9 +18,9 @@

#include <mach-o/nlist.h>

#include <sys/types.h>

+#include <memory>

#include <utility>

-#include "base/memory/scoped_ptr.h"

#include "base/strings/stringprintf.h"

#include "util/mac/checked_mach_address_range.h"

#include "util/mach/task_memory.h"

@@ -100,7 +100,7 @@ class MachOImageSymbolTableReaderInitializer {

return false;

}

- scoped_ptr<process_types::nlist[]> symbols(

+ std::unique_ptr<process_types::nlist[]> symbols(

new process_types::nlist[symtab_command->nsyms]);

if (!process_types::nlist::ReadArrayInto(

process_reader_, symtab_address, symbol_count, &symbols[0])) {

@@ -108,7 +108,7 @@ class MachOImageSymbolTableReaderInitializer {

return false;

}

- scoped_ptr<TaskMemory::MappedMemory> string_table;

+ std::unique_ptr<TaskMemory::MappedMemory> string_table;

for (size_t symbol_index = 0; symbol_index < symbol_count; ++symbol_index) {

const process_types::nlist& symbol = symbols[symbol_index];

std::string symbol_info = base::StringPrintf(", symbol index %zu%s",