third_party/crashpad/crashpad/tools/tool_support.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/tools/tool_support.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/tools/generate_dump.cc ('k') | third_party/crashpad/crashpad/util/mach/exc_server_variants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/tools/tool_support.cc

diff --git a/third_party/crashpad/crashpad/tools/tool_support.cc b/third_party/crashpad/crashpad/tools/tool_support.cc

index 5d3592bcfdf92bc95ddd89c296ea78486af74163..f6d4f84c06a0e38c49873de2398e14965d3d4f5c 100644

--- a/third_party/crashpad/crashpad/tools/tool_support.cc

+++ b/third_party/crashpad/crashpad/tools/tool_support.cc

@@ -16,9 +16,9 @@

#include <stdio.h>

+#include <memory>

#include <vector>

-#include "base/memory/scoped_ptr.h"

#include "base/strings/utf_string_conversions.h"

#include "package.h"

@@ -75,7 +75,7 @@ void ToolSupport::UsageHint(const std::string& me, const char* hint) {

// static

int ToolSupport::Wmain(int argc, wchar_t* argv[], int (*entry)(int, char* [])) {

- scoped_ptr<char* []> argv_as_utf8(new char* [argc + 1]);

+ std::unique_ptr<char* []> argv_as_utf8(new char*[argc + 1]);

std::vector<std::string> storage;

storage.reserve(argc);

for (int i = 0; i < argc; ++i) {