third_party/crashpad/crashpad/tools/generate_dump.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/crashpad/crashpad/tools/generate_dump.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/crashpad/crashpad/tools/crashpad_database_util.cc ('k') | third_party/crashpad/crashpad/tools/tool_support.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/crashpad/crashpad/tools/generate_dump.cc

diff --git a/third_party/crashpad/crashpad/tools/generate_dump.cc b/third_party/crashpad/crashpad/tools/generate_dump.cc

index 23b21ef64463d6fb7e98e54b3c32450b5debd8a6..399216106af9242616481b1432594d002f45b7c5 100644

--- a/third_party/crashpad/crashpad/tools/generate_dump.cc

+++ b/third_party/crashpad/crashpad/tools/generate_dump.cc

@@ -18,10 +18,10 @@

#include <stdlib.h>

#include <sys/types.h>

+#include <memory>

#include <string>

#include "base/logging.h"

-#include "base/memory/scoped_ptr.h"

#include "base/strings/stringprintf.h"

#include "build/build_config.h"

#include "minidump/minidump_file_writer.h"

@@ -165,12 +165,12 @@ int GenerateDumpMain(int argc, char* argv[]) {

{

#if defined(OS_MACOSX)

- scoped_ptr<ScopedTaskSuspend> suspend;

+ std::unique_ptr<ScopedTaskSuspend> suspend;

if (options.suspend) {

suspend.reset(new ScopedTaskSuspend(task));

}

#elif defined(OS_WIN)

- scoped_ptr<ScopedProcessSuspend> suspend;

+ std::unique_ptr<ScopedProcessSuspend> suspend;

if (options.suspend) {

suspend.reset(new ScopedProcessSuspend(process.get()));

}