Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

BUG=554298
Committed: https://crrev.com/7bacc0eaa9eb6edb22c9e2734e0e57e64e8b4125
Cr-Commit-Position: refs/heads/master@{#386453}

[dcheng, 2016-04-08 05:14:01]

dcheng@chromium.org changed reviewers:
+ nparker@chromium.org

[dcheng, 2016-04-08 05:14:02]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[Nathan Parker, 2016-04-11 17:56:44]

lgtm

I added some comments before reading your "out of scope for this CL" note, so
feel free to ignore if you'd like.

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/download_feedback.h (right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/download_feedback.h:10: #include <memory>
We probably don't need this,

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc
(right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc:7:
#include "base/logging.h"
include memory?

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
(right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc:196:
callback.Run(base::WrapUnique(download_metadata->release_download()));
Should every use of WrapUnique also include <memory>?

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ui_manager.h (right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ui_manager.h:11: #include <memory>
not needed

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ui_manager_unittest.cc (right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ui_manager_unittest.cc:6: 
maybe not needed

[dcheng, 2016-04-11 18:31:15]

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/download_feedback.h (right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/download_feedback.h:10: #include <memory>
On 2016/04/11 17:56:44, Nathan Parker wrote:
> We probably don't need this,

Done.

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc
(right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/binary_integrity_incident.cc:7:
#include "base/logging.h"
On 2016/04/11 17:56:44, Nathan Parker wrote:
> include memory?

Usually if the "primary" header already includes a header, I don't duplicate it
in the CC. Is that OK?

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File
chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc
(right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/incident_reporting/download_metadata_manager.cc:196:
callback.Run(base::WrapUnique(download_metadata->release_download()));
On 2016/04/11 17:56:44, Nathan Parker wrote:
> Should every use of WrapUnique also include <memory>?

The jury's out on that one. On one hand, it's part of WrapUnique's contract, so
including it seems redundant... on the other, it's weird to see unique_ptr
without the corresponding header actually included.

I have an OKR of figuring out some same set of IWYU rules to try to apply. I'm
not sure how much progress I'll be able to make on it... but I'm definitely
thinking about it.

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ui_manager.h (right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ui_manager.h:11: #include <memory>
On 2016/04/11 17:56:44, Nathan Parker wrote:
> not needed

Done.

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
File chrome/browser/safe_browsing/ui_manager_unittest.cc (right):

https://codereview.chromium.org/1870003002/diff/1/chrome/browser/safe_browsin...
chrome/browser/safe_browsing/ui_manager_unittest.cc:6: 
On 2016/04/11 17:56:44, Nathan Parker wrote:
> maybe not needed

Done.

[dcheng, 2016-04-11 19:44:23]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-11 19:44:24]

The patchset sent to the CQ was uploaded after l-g-t-m from nparker@chromium.org
Link to the patchset: https://codereview.chromium.org/1870003002/#ps20001
(title: "Rebase and address comments")

[commit-bot: I haz the power, 2016-04-11 19:45:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1870003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1870003002/20001

[commit-bot: I haz the power, 2016-04-11 20:11:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-11 20:11:58]

Description was changed from

==========
Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

BUG=554298

Committed: https://crrev.com/7bacc0eaa9eb6edb22c9e2734e0e57e64e8b4125
Cr-Commit-Position: refs/heads/master@{#386453}
==========

[commit-bot: I haz the power, 2016-04-11 20:12:00]

Patchset 2 (id:??) landed as
https://crrev.com/7bacc0eaa9eb6edb22c9e2734e0e57e64e8b4125
Cr-Commit-Position: refs/heads/master@{#386453}