chrome/browser/safe_browsing/download_feedback_service.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_feedback_service.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_feedback_service.h ('k') | chrome/browser/safe_browsing/download_protection_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_feedback_service.cc

diff --git a/chrome/browser/safe_browsing/download_feedback_service.cc b/chrome/browser/safe_browsing/download_feedback_service.cc

index efc81f2e5e9abfd61cc57feabeb5871ff85ee536..9eb9b0905847c2f1568eb1fcea1c57bfe6b13139 100644

--- a/chrome/browser/safe_browsing/download_feedback_service.cc

+++ b/chrome/browser/safe_browsing/download_feedback_service.cc

@@ -187,12 +187,9 @@ void DownloadFeedbackService::BeginFeedback(

const std::string& ping_response,

const base::FilePath& path) {

DCHECK(CalledOnValidThread());

- scoped_ptr<DownloadFeedback> feedback(

- DownloadFeedback::Create(request_context_getter_.get(),

- file_task_runner_.get(),

- path,

- ping_request,

- ping_response));

+ std::unique_ptr<DownloadFeedback> feedback(DownloadFeedback::Create(

+ request_context_getter_.get(), file_task_runner_.get(), path,

+ ping_request, ping_response));

active_feedback_.push_back(std::move(feedback));

UMA_HISTOGRAM_COUNTS_100("SBDownloadFeedback.ActiveFeedbacks",

active_feedback_.size());