chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/state_store.cc ('k') | chrome/browser/safe_browsing/incident_reporting/suspicious_module_incident.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

index f6ec4d0b1eae92270f111f65859ee2f3b9d7db44..5f5aba52c983b261ca8db6401599f2f625fe3e42 100644

--- a/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc

@@ -93,8 +93,8 @@ class StateStoreTest : public PlatformStateStoreTestBase {

// store.

void TrimPref() {

ASSERT_EQ(nullptr, profile_);

- scoped_ptr<base::Value> prefs(JSONFileValueDeserializer(GetPrefsPath())

- .Deserialize(nullptr, nullptr));

+ std::unique_ptr<base::Value> prefs(JSONFileValueDeserializer(GetPrefsPath())

+ .Deserialize(nullptr, nullptr));

ASSERT_NE(nullptr, prefs.get());

base::DictionaryValue* dict = nullptr;

ASSERT_TRUE(prefs->GetAsDictionary(&dict));