chrome/browser/safe_browsing/safe_browsing_tab_observer.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_tab_observer.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_tab_observer.h ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_tab_observer.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc b/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc

index 3c5202fbaecf8f99433e10ae22ba4615d76aac2f..d5dc3f55f7219e315400dfe4a12f9f9f5103b5a9 100644

--- a/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc

@@ -24,7 +24,8 @@ DEFINE_WEB_CONTENTS_USER_DATA_KEY(safe_browsing::SafeBrowsingTabObserver);

namespace safe_browsing {

#if !defined(SAFE_BROWSING_CSD)

-// Provide a dummy implementation so that scoped_ptr<ClientSideDetectionHost>

+// Provide a dummy implementation so that

+// std::unique_ptr<ClientSideDetectionHost>

// has a concrete destructor to call. This is necessary because it is used

// as a member of SafeBrowsingTabObserver, even if it only ever contains NULL.

// TODO(shess): This is weird, why not just guard the instance variable?

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_tab_observer.h ('k') | chrome/browser/safe_browsing/safe_browsing_test.cc » ('j') | no next file with comments »