chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h

index e428537880702dc52021d527d7458efadd87c6fe..9bb697f541277e2493e47a9b24090bfbdf872799 100644

--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h

+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer.h

@@ -7,9 +7,9 @@

#include <stddef.h>

+#include <memory>

#include <string>

-#include "base/memory/scoped_ptr.h"

namespace base {

class FilePath;

@@ -27,7 +27,7 @@ void RegisterBinaryIntegrityAnalysis();

// Callback to pass to the incident reporting service. The incident reporting

// service will decide when to start the analysis.

-void VerifyBinaryIntegrity(scoped_ptr<IncidentReceiver> incident_receiver);

+void VerifyBinaryIntegrity(std::unique_ptr<IncidentReceiver> incident_receiver);

// Record how long the signature verification took.

void RecordSignatureVerificationTime(size_t file_index,