chrome/browser/safe_browsing/ping_manager.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/ping_manager.cc

diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc

index c7d681fd1a05260dbb05636b01f86247edca01e4..0a6908db57f336892cdd143ce1de4c655b40da1c 100644

--- a/chrome/browser/safe_browsing/ping_manager.cc

+++ b/chrome/browser/safe_browsing/ping_manager.cc

@@ -136,7 +136,7 @@ void SafeBrowsingPingManager::ReportInvalidCertificateChain(

}

void SafeBrowsingPingManager::SetCertificateErrorReporterForTesting(

- scoped_ptr<certificate_reporting::ErrorReporter>

+ std::unique_ptr<certificate_reporting::ErrorReporter>

certificate_error_reporter) {

certificate_error_reporter_ = std::move(certificate_error_reporter);

}

« no previous file with comments | « chrome/browser/safe_browsing/ping_manager.h ('k') | chrome/browser/safe_browsing/protocol_manager.h » ('j') | no next file with comments »