chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/mock_incident_receiver.h ('k') | chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc

index d3460a282d4c2d7b551d1f3a6b9466e94bbffa0d..1e6c3cb076a3f50c9c4d011f07f0e5308d851139 100644

--- a/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/module_integrity_verifier_win_unittest.cc

@@ -10,12 +10,12 @@

#include <algorithm>

#include <functional>

#include <map>

+#include <memory>

#include <vector>

#include "base/files/file_path.h"

#include "base/files/memory_mapped_file.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/native_library.h"

#include "base/scoped_native_library.h"

#include "base/strings/utf_string_conversions.h"

@@ -157,8 +157,8 @@ class SafeBrowsingModuleVerifierWinTest : public testing::Test {

base::ScopedNativeLibrary mem_dll_handle_;

base::MemoryMappedFile disk_dll_handle_;

- scoped_ptr<base::win::PEImageAsData> disk_peimage_ptr_;

- scoped_ptr<base::win::PEImage> mem_peimage_ptr_;

+ std::unique_ptr<base::win::PEImageAsData> disk_peimage_ptr_;

+ std::unique_ptr<base::win::PEImage> mem_peimage_ptr_;

};

// Don't run these tests under AddressSanitizer as it patches the modules on