Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Side by Side Diff: chrome/browser/safe_browsing/incident_reporting/tracked_preference_incident_unittest.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/incident_reporting/tracked_preference_inc ident.h" 5 #include "chrome/browser/safe_browsing/incident_reporting/tracked_preference_inc ident.h"
6 6
7 #include <memory>
7 #include <utility> 8 #include <utility>
8 9
9 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/ptr_util.h"
10 #include "chrome/common/safe_browsing/csd.pb.h" 11 #include "chrome/common/safe_browsing/csd.pb.h"
11 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
12 13
13 namespace safe_browsing { 14 namespace safe_browsing {
14 15
15 namespace { 16 namespace {
16 17
17 scoped_ptr<Incident> MakeIncident(bool changed, bool is_personal) { 18 std::unique_ptr<Incident> MakeIncident(bool changed, bool is_personal) {
18 scoped_ptr<ClientIncidentReport_IncidentData_TrackedPreferenceIncident> 19 std::unique_ptr<ClientIncidentReport_IncidentData_TrackedPreferenceIncident>
19 incident(new ClientIncidentReport_IncidentData_TrackedPreferenceIncident); 20 incident(new ClientIncidentReport_IncidentData_TrackedPreferenceIncident);
20 21
21 incident->set_path("foo"); 22 incident->set_path("foo");
22 incident->set_atomic_value("bar"); 23 incident->set_atomic_value("bar");
23 incident->set_value_state( 24 incident->set_value_state(
24 changed 25 changed
25 ? ClientIncidentReport_IncidentData_TrackedPreferenceIncident_ValueSta te_CHANGED 26 ? ClientIncidentReport_IncidentData_TrackedPreferenceIncident_ValueSta te_CHANGED
26 : ClientIncidentReport_IncidentData_TrackedPreferenceIncident_ValueSta te_CLEARED); 27 : ClientIncidentReport_IncidentData_TrackedPreferenceIncident_ValueSta te_CLEARED);
27 return make_scoped_ptr( 28 return base::WrapUnique(
28 new TrackedPreferenceIncident(std::move(incident), is_personal)); 29 new TrackedPreferenceIncident(std::move(incident), is_personal));
29 } 30 }
30 31
31 } // namespace 32 } // namespace
32 33
33 TEST(TrackedPreferenceIncident, GetType) { 34 TEST(TrackedPreferenceIncident, GetType) {
34 ASSERT_EQ(IncidentType::TRACKED_PREFERENCE, 35 ASSERT_EQ(IncidentType::TRACKED_PREFERENCE,
35 MakeIncident(false, false)->GetType()); 36 MakeIncident(false, false)->GetType());
36 } 37 }
37 38
38 // Tests that GetKey returns the preference path. 39 // Tests that GetKey returns the preference path.
39 TEST(TrackedPreferenceIncident, KeyIsPath) { 40 TEST(TrackedPreferenceIncident, KeyIsPath) {
40 ASSERT_EQ(std::string("foo"), MakeIncident(false, false)->GetKey()); 41 ASSERT_EQ(std::string("foo"), MakeIncident(false, false)->GetKey());
41 } 42 }
42 43
43 // Tests that GetDigest returns the same value for the same incident. 44 // Tests that GetDigest returns the same value for the same incident.
44 TEST(TrackedPreferenceIncident, SameIncidentSameDigest) { 45 TEST(TrackedPreferenceIncident, SameIncidentSameDigest) {
45 ASSERT_EQ(MakeIncident(false, false)->ComputeDigest(), 46 ASSERT_EQ(MakeIncident(false, false)->ComputeDigest(),
46 MakeIncident(false, false)->ComputeDigest()); 47 MakeIncident(false, false)->ComputeDigest());
47 } 48 }
48 49
49 // Tests that GetDigest returns a different value for different incidents. 50 // Tests that GetDigest returns a different value for different incidents.
50 TEST(TrackedPreferenceIncident, DifferentIncidentDifferentDigest) { 51 TEST(TrackedPreferenceIncident, DifferentIncidentDifferentDigest) {
51 ASSERT_NE(MakeIncident(false, false)->ComputeDigest(), 52 ASSERT_NE(MakeIncident(false, false)->ComputeDigest(),
52 MakeIncident(true, false)->ComputeDigest()); 53 MakeIncident(true, false)->ComputeDigest());
53 } 54 }
54 55
55 // Tests that values are removed for personal preferences. 56 // Tests that values are removed for personal preferences.
56 TEST(TrackedPreferenceIncident, Filter) { 57 TEST(TrackedPreferenceIncident, Filter) {
57 scoped_ptr<ClientIncidentReport_IncidentData> impersonal( 58 std::unique_ptr<ClientIncidentReport_IncidentData> impersonal(
58 MakeIncident(false, false)->TakePayload()); 59 MakeIncident(false, false)->TakePayload());
59 ASSERT_TRUE(impersonal->tracked_preference().has_atomic_value()); 60 ASSERT_TRUE(impersonal->tracked_preference().has_atomic_value());
60 61
61 scoped_ptr<ClientIncidentReport_IncidentData> personal( 62 std::unique_ptr<ClientIncidentReport_IncidentData> personal(
62 MakeIncident(false, true)->TakePayload()); 63 MakeIncident(false, true)->TakePayload());
63 ASSERT_FALSE(personal->tracked_preference().has_atomic_value()); 64 ASSERT_FALSE(personal->tracked_preference().has_atomic_value());
64 } 65 }
65 66
66 } // namespace safe_browsing 67 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698