chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/extension_data_collection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

index aef3e5468c0e9a8eaf056ffd8291439737f193fd..bb067db15f2841c992666181725d2b6e30a729bf 100644

--- a/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc

@@ -6,13 +6,13 @@

#include <stdint.h>

+#include <memory>

#include <set>

#include <string>

#include "base/i18n/case_conversion.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram_macros.h"

#include "base/strings/string16.h"

#include "base/strings/string_util.h"

@@ -254,7 +254,7 @@ void CollectModuleVerificationData(

using ModuleState = ClientIncidentReport_EnvironmentData_Process_ModuleState;

for (size_t i = 0; i < num_modules_to_verify; ++i) {

- scoped_ptr<ModuleState> module_state(new ModuleState());

+ std::unique_ptr<ModuleState> module_state(new ModuleState());

int num_bytes_different = 0;

bool scan_complete = VerifyModule(modules_to_verify[i],