Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4943)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc
index da95cdd51e60f2e2e946bf7875175450f0b10c5f..d55b9677bcf16464b2c92f5ee3774f597582b975 100644
--- a/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl_unittest.cc
@@ -21,7 +21,7 @@ class IncidentReportUploaderImplTest : public testing::Test {
// safe_browsing::IncidentReportUploader::OnResultCallback implementation.
void OnReportUploadResult(
safe_browsing::IncidentReportUploader::Result result,
- scoped_ptr<safe_browsing::ClientIncidentResponse> response) {
+ std::unique_ptr<safe_browsing::ClientIncidentResponse> response) {
result_ = result;
response_ = std::move(response);
}
@@ -34,17 +34,16 @@ class IncidentReportUploaderImplTest : public testing::Test {
scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
net::TestURLFetcherFactory url_fetcher_factory_;
safe_browsing::IncidentReportUploader::Result result_;
- scoped_ptr<safe_browsing::ClientIncidentResponse> response_;
+ std::unique_ptr<safe_browsing::ClientIncidentResponse> response_;
};
TEST_F(IncidentReportUploaderImplTest, Success) {
safe_browsing::ClientIncidentReport report;
- scoped_ptr<safe_browsing::IncidentReportUploader> instance(
+ std::unique_ptr<safe_browsing::IncidentReportUploader> instance(
safe_browsing::IncidentReportUploaderImpl::UploadReport(
base::Bind(&IncidentReportUploaderImplTest::OnReportUploadResult,
base::Unretained(this)),
- NULL,
- report));
+ NULL, report));
net::TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(
safe_browsing::IncidentReportUploaderImpl::kTestUrlFetcherId);

Powered by Google App Engine
This is Rietveld 408576698