chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc ('k') | chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h

index d983905c823c0e5808bb72eb770919e4f8767cf2..93b80399cd85b9e13db20354f728b7288c6f24fb 100644

--- a/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h

+++ b/chrome/browser/safe_browsing/incident_reporting/blacklist_load_incident.h

@@ -7,8 +7,9 @@

#include <stdint.h>

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/safe_browsing/incident_reporting/incident.h"

namespace safe_browsing {

@@ -18,8 +19,9 @@ class ClientIncidentReport_IncidentData_BlacklistLoadIncident;

// An incident representing a module that evades the browser DLL blacklist.

class BlacklistLoadIncident : public Incident {

public:

- explicit BlacklistLoadIncident(scoped_ptr<

- ClientIncidentReport_IncidentData_BlacklistLoadIncident> blacklist_load);

+ explicit BlacklistLoadIncident(

+ std::unique_ptr<ClientIncidentReport_IncidentData_BlacklistLoadIncident>

+ blacklist_load);

~BlacklistLoadIncident() override;

// Incident methods: