chrome/browser/safe_browsing/protocol_parser.h - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/protocol_parser.h

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/protocol_parser.h

diff --git a/chrome/browser/safe_browsing/protocol_parser.h b/chrome/browser/safe_browsing/protocol_parser.h

index c743b836c5f2e8c04381b24a853cc0c15c572645..ae356a22b1e9f1d2c002fb1a38eb1b2fb3d7ebca 100644

--- a/chrome/browser/safe_browsing/protocol_parser.h

+++ b/chrome/browser/safe_browsing/protocol_parser.h

@@ -45,7 +45,7 @@ bool ParseUpdate(const char* chunk_data,

// results should be discarded.

bool ParseChunk(const char* chunk_data,

size_t chunk_len,

- std::vector<scoped_ptr<SBChunkData>>* chunks);

+ std::vector<std::unique_ptr<SBChunkData>>* chunks);

// Parse body of "HTTP Response for Full-Length Hashes", returning the list of

// full hashes. Returns |false| if the data could not be parsed correctly, in

« no previous file with comments | « chrome/browser/safe_browsing/protocol_manager_unittest.cc ('k') | chrome/browser/safe_browsing/protocol_parser.cc » ('j') | no next file with comments »