chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/resource_request_incident.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h

diff --git a/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h b/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h

index 2a602509371bfaf949d7516260fc54d93deebe3c..af26aa0f216b6f60e6cf16dccc712c7b5c991f55 100644

--- a/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h

+++ b/chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h

@@ -7,8 +7,9 @@

#include <stdint.h>

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "chrome/browser/safe_browsing/incident_reporting/incident.h"

namespace safe_browsing {

@@ -19,7 +20,7 @@ class ClientIncidentReport_IncidentData_ResourceRequestIncident;

class ResourceRequestIncident : public Incident {

public:

explicit ResourceRequestIncident(

- scoped_ptr<ClientIncidentReport_IncidentData_ResourceRequestIncident>

+ std::unique_ptr<ClientIncidentReport_IncidentData_ResourceRequestIncident>

script_detection_incident);

~ResourceRequestIncident() override;