Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1846253003: Revert of Refactor content/common/gpu into gpu/ipc/service (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor content/common/gpu into gpu/ipc/service (patchset #15 id:280001 of https://codereview.chromium.org/1845563005/ ) Reason for revert: Speculating that this CL might be responsible for closing the tree broken here: https://build.chromium.org/p/chromium/builders/Win/builds/41941 Original issue's description: > Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger refactor for Mus (see label:gpurefactor). > > BUG=586385 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99 > Cr-Commit-Position: refs/heads/master@{#384705} TBR=sadrul@chromium.org,ccameron@chromium.org,rjkroege@chromium.org,bsalomon@google.com,dpranke@chromium.org,piman@chromium.org,markdittmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586385 Committed: https://crrev.com/9a90e8abe1d64cd35f7fb53370b28007f27c6c59 Cr-Commit-Position: refs/heads/master@{#384715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9497 lines, -9780 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 5 chunks +20 lines, -4 lines 0 comments Download
A content/common/gpu/ca_layer_partial_damage_tree_mac.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/common/gpu/ca_layer_partial_damage_tree_mac.mm View 1 chunk +287 lines, -0 lines 0 comments Download
A content/common/gpu/ca_layer_tree_mac.h View 1 chunk +202 lines, -0 lines 0 comments Download
A content/common/gpu/ca_layer_tree_mac.mm View 1 chunk +568 lines, -0 lines 0 comments Download
A content/common/gpu/ca_layer_tree_unittest_mac.mm View 1 chunk +852 lines, -0 lines 0 comments Download
A content/common/gpu/child_window_surface_win.h View 1 chunk +48 lines, -0 lines 0 comments Download
A content/common/gpu/child_window_surface_win.cc View 1 chunk +228 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel.h View 1 chunk +483 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel.cc View 1 chunk +1053 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_manager.h View 1 chunk +228 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_manager.cc View 1 chunk +309 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_manager_delegate.h View 1 chunk +91 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_manager_unittest.cc View 1 chunk +101 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_test_common.h View 1 chunk +135 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_test_common.cc View 1 chunk +169 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_channel_unittest.cc View 1 chunk +291 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +286 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +1143 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_config.h View 1 chunk +12 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory.h View 1 chunk +67 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_io_surface.h View 1 chunk +77 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_io_surface.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_io_surface_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.h View 1 chunk +67 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 chunk +128 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_surface_texture.h View 1 chunk +72 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_surface_texture.cc View 1 chunk +108 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_surface_texture_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_buffer_factory_test_template.h View 1 chunk +99 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_manager.h View 1 chunk +81 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_manager.cc View 1 chunk +125 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_tracking.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_memory_tracking.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A content/common/gpu/gpu_watchdog.h View 1 chunk +28 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface.h View 1 chunk +47 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_android.cc View 1 chunk +41 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_linux.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_mac.mm View 1 chunk +80 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_overlay_mac.h View 1 chunk +158 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_overlay_mac.mm View 1 chunk +563 lines, -0 lines 0 comments Download
A content/common/gpu/image_transport_surface_win.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M content/common/gpu/media/android_deferred_rendering_backing_strategy.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/common/gpu/media/android_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/android_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/gpu_jpeg_decode_accelerator.h View 3 chunks +4 lines, -6 lines 0 comments Download
M content/common/gpu/media/gpu_jpeg_decode_accelerator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 4 chunks +7 lines, -7 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.h View 4 chunks +6 lines, -7 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/common/gpu/media/media_channel.h View 2 chunks +4 lines, -7 lines 0 comments Download
M content/common/gpu/media/media_channel.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/common/gpu/media/media_service.h View 2 chunks +4 lines, -7 lines 0 comments Download
M content/common/gpu/media/media_service.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/common/gpu/media/vaapi_jpeg_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
A content/common/gpu/pass_through_image_transport_surface.h View 1 chunk +73 lines, -0 lines 0 comments Download
A content/common/gpu/pass_through_image_transport_surface.cc View 1 chunk +175 lines, -0 lines 0 comments Download
A content/common/gpu/stream_texture_android.h View 1 chunk +111 lines, -0 lines 0 comments Download
A content/common/gpu/stream_texture_android.cc View 1 chunk +277 lines, -0 lines 0 comments Download
A content/common/gpu/x_util.h View 1 chunk +40 lines, -0 lines 0 comments Download
M content/content_common.gypi View 7 chunks +45 lines, -5 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 5 chunks +15 lines, -1 line 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 7 chunks +15 lines, -15 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/gpu/gpu_main.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/in_process_gpu_thread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/in_process_gpu_thread.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/valuebuffer_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu.gyp View 9 chunks +6 lines, -84 lines 0 comments Download
D gpu/gpu_ipc_service.gypi View 1 chunk +0 lines, -102 lines 0 comments Download
D gpu/ipc/service/BUILD.gn View 1 chunk +0 lines, -162 lines 0 comments Download
D gpu/ipc/service/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D gpu/ipc/service/ca_layer_partial_damage_tree_mac.h View 1 chunk +0 lines, -56 lines 0 comments Download
D gpu/ipc/service/ca_layer_partial_damage_tree_mac.mm View 1 chunk +0 lines, -287 lines 0 comments Download
D gpu/ipc/service/ca_layer_tree_mac.h View 1 chunk +0 lines, -202 lines 0 comments Download
D gpu/ipc/service/ca_layer_tree_mac.mm View 1 chunk +0 lines, -568 lines 0 comments Download
D gpu/ipc/service/ca_layer_tree_unittest_mac.mm View 1 chunk +0 lines, -852 lines 0 comments Download
D gpu/ipc/service/child_window_surface_win.h View 1 chunk +0 lines, -48 lines 0 comments Download
D gpu/ipc/service/child_window_surface_win.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D gpu/ipc/service/gpu_channel.h View 1 chunk +0 lines, -482 lines 0 comments Download
D gpu/ipc/service/gpu_channel.cc View 1 chunk +0 lines, -1053 lines 0 comments Download
D gpu/ipc/service/gpu_channel_manager.h View 1 chunk +0 lines, -228 lines 0 comments Download
D gpu/ipc/service/gpu_channel_manager.cc View 1 chunk +0 lines, -309 lines 0 comments Download
D gpu/ipc/service/gpu_channel_manager_delegate.h View 1 chunk +0 lines, -89 lines 0 comments Download
D gpu/ipc/service/gpu_channel_manager_unittest.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D gpu/ipc/service/gpu_channel_test_common.h View 1 chunk +0 lines, -135 lines 0 comments Download
D gpu/ipc/service/gpu_channel_test_common.cc View 1 chunk +0 lines, -169 lines 0 comments Download
D gpu/ipc/service/gpu_channel_unittest.cc View 1 chunk +0 lines, -291 lines 0 comments Download
D gpu/ipc/service/gpu_command_buffer_stub.h View 1 chunk +0 lines, -286 lines 0 comments Download
D gpu/ipc/service/gpu_command_buffer_stub.cc View 1 chunk +0 lines, -1143 lines 0 comments Download
D gpu/ipc/service/gpu_config.h View 1 chunk +0 lines, -12 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory.h View 1 chunk +0 lines, -65 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_io_surface.h View 1 chunk +0 lines, -77 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_io_surface.cc View 1 chunk +0 lines, -100 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_io_surface_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.h View 1 chunk +0 lines, -67 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 1 chunk +0 lines, -128 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.h View 1 chunk +0 lines, -72 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_surface_texture.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_surface_texture_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D gpu/ipc/service/gpu_memory_buffer_factory_test_template.h View 1 chunk +0 lines, -99 lines 0 comments Download
D gpu/ipc/service/gpu_memory_manager.h View 1 chunk +0 lines, -78 lines 0 comments Download
D gpu/ipc/service/gpu_memory_manager.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D gpu/ipc/service/gpu_memory_tracking.h View 1 chunk +0 lines, -53 lines 0 comments Download
D gpu/ipc/service/gpu_memory_tracking.cc View 1 chunk +0 lines, -37 lines 0 comments Download
D gpu/ipc/service/gpu_watchdog.h View 1 chunk +0 lines, -28 lines 0 comments Download
D gpu/ipc/service/image_transport_surface.h View 1 chunk +0 lines, -47 lines 0 comments Download
D gpu/ipc/service/image_transport_surface_android.cc View 1 chunk +0 lines, -41 lines 0 comments Download
D gpu/ipc/service/image_transport_surface_linux.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D gpu/ipc/service/image_transport_surface_mac.mm View 1 chunk +0 lines, -80 lines 0 comments Download
D gpu/ipc/service/image_transport_surface_overlay_mac.h View 1 chunk +0 lines, -158 lines 0 comments Download
D gpu/ipc/service/image_transport_surface_overlay_mac.mm View 1 chunk +0 lines, -563 lines 0 comments Download
D gpu/ipc/service/image_transport_surface_win.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D gpu/ipc/service/pass_through_image_transport_surface.h View 1 chunk +0 lines, -73 lines 0 comments Download
D gpu/ipc/service/pass_through_image_transport_surface.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D gpu/ipc/service/stream_texture_android.h View 1 chunk +0 lines, -111 lines 0 comments Download
D gpu/ipc/service/stream_texture_android.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D gpu/ipc/service/x_util.h View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Łukasz Anforowicz
Created Revert of Refactor content/common/gpu into gpu/ipc/service
4 years, 8 months ago (2016-04-01 23:03:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846253003/1
4 years, 8 months ago (2016-04-01 23:03:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 23:06:11 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:08:15 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a90e8abe1d64cd35f7fb53370b28007f27c6c59
Cr-Commit-Position: refs/heads/master@{#384715}

Powered by Google App Engine
This is Rietveld 408576698