Refactor content/common/gpu into gpu/ipc/service

Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}

Committed: https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
Cr-Commit-Position: refs/heads/master@{#386084}

[Mark Dittmer, 2016-03-30 20:04:09]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service

BUG=586385
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Mark Dittmer, 2016-03-30 20:06:10]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 20:06:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/1

[commit-bot: I haz the power, 2016-03-30 20:12:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 20:12:12]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-30 20:51:06]

Add missing deps based on bot failures

[Mark Dittmer, 2016-03-30 20:52:35]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 20:52:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/20001

[commit-bot: I haz the power, 2016-03-30 20:58:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 20:58:26]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-30 22:28:59]

Fix some mac and ozone deps

[Mark Dittmer, 2016-03-30 22:29:48]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 22:30:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/40001

[commit-bot: I haz the power, 2016-03-30 22:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:35:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Mark Dittmer, 2016-03-31 13:49:11]

Fix Mac build errors

[Mark Dittmer, 2016-03-31 14:45:15]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Mark Dittmer, 2016-03-31 14:45:15]

markdittmer@chromium.org changed reviewers:
+ bsalomon@chromium.org, ccameron@chromium.org, rjkroege@chromium.org,
sadrul@chromium.org

[Mark Dittmer, 2016-03-31 14:47:18]

Initial reviewers: please review code in mentioned locations, and new
gpu/ipc/service/DEPS on said locations.

bsalomon@: third_party/skia;
sadrul@: ui/base, ui/events;
ccameron@: ui/accelerated_widget_mac;
rjkroege@: ui/ozone

[Mark Dittmer, 2016-03-31 14:50:12]

Rebase and fix missing ozone dep

[Mark Dittmer, 2016-03-31 14:50:50]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 14:50:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/80001

[commit-bot: I haz the power, 2016-03-31 14:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 14:57:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Mark Dittmer, 2016-03-31 15:42:01]

markdittmer@chromium.org changed reviewers:
+ bsalomon@google.com
- bsalomon@chromium.org

[Mark Dittmer, 2016-03-31 15:42:09]

Fixes for Mac and Android builds

[Mark Dittmer, 2016-03-31 16:07:10]

Fix gn libs defs

[Mark Dittmer, 2016-03-31 16:10:54]

markdittmer@chromium.org changed reviewers:
+ dpranke@chromium.org, piman@chromium.org

[Mark Dittmer, 2016-03-31 16:12:19]

Added/modified reviewers:

dpranke@: PTAL @ top-level BULID.gn;
piman@ and ccameron@: PTAL @ content/common;
piman@: PTAL @ gpu/ipc/service

[Mark Dittmer, 2016-03-31 16:14:31]

Fix gn libs defs

[Dirk Pranke, 2016-03-31 18:39:09]

//BUILD.gn lgtm. I didn't really look at the rest; let me know if you want me to
do so.

[piman, 2016-03-31 19:26:17]

LGTM modulo link issue

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
File content/common/gpu/client/gpu_channel_host.h (right):

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
content/common/gpu/client/gpu_channel_host.h:64: // On the GPU process side
there's a corresponding gpu::GpuChannel.
nit: this will conflict with https://codereview.chromium.org/1827123002/, which
also makes it not needed any more. I suggest removing from this CL.

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_test_template.h (right):

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_test_template.h:5: // This file
defines tests that implementations of gpu::GpuMemoryBufferFactory
nit: same here

[Mark Dittmer, 2016-03-31 19:40:44]

Fix mac GN unittests

[Mark Dittmer, 2016-03-31 19:56:38]

Drop gpu:: qualification from comments

[Mark Dittmer, 2016-03-31 19:57:34]

Fixed piman@'s nits.

rjkroege@, sadrul@, ccameron@, bsalomon@ PTAL.

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
File content/common/gpu/client/gpu_channel_host.h (right):

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
content/common/gpu/client/gpu_channel_host.h:64: // On the GPU process side
there's a corresponding gpu::GpuChannel.
On 2016/03/31 19:26:16, piman wrote:
> nit: this will conflict with https://codereview.chromium.org/1827123002/,
which
> also makes it not needed any more. I suggest removing from this CL.

Done.

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
File content/common/gpu/client/gpu_memory_buffer_impl_test_template.h (right):

https://codereview.chromium.org/1845563005/diff/140001/content/common/gpu/cli...
content/common/gpu/client/gpu_memory_buffer_impl_test_template.h:5: // This file
defines tests that implementations of gpu::GpuMemoryBufferFactory
On 2016/03/31 19:26:16, piman wrote:
> nit: same here

Done.

[ccameron, 2016-03-31 20:05:02]

On 2016/03/31 14:47:18, Mark Dittmer wrote:
> Initial reviewers: please review code in mentioned locations, and new
> gpu/ipc/service/DEPS on said locations.
> 
> ccameron@: ui/accelerated_widget_mac;

I'm not seeing changes here...?

[chromium-reviews, 2016-03-31 20:17:21]

There is a new DEPS reference in gpu/ipc/service. Does it look good to you?
On 31 Mar 2016 4:05 p.m., <ccameron@chromium.org> wrote:

> On 2016/03/31 14:47:18, Mark Dittmer wrote:
> > Initial reviewers: please review code in mentioned locations, and new
> > gpu/ipc/service/DEPS on said locations.
> >
> > ccameron@: ui/accelerated_widget_mac;
>
> I'm not seeing changes here...?
>
> https://codereview.chromium.org/1845563005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Dittmer, 2016-03-31 20:23:36]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 20:24:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/180001

[commit-bot: I haz the power, 2016-03-31 20:39:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 20:39:34]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rjkroege, 2016-03-31 20:53:44]

*ozone* changes lgtm

[bsalomon, 2016-03-31 20:55:41]

skia dependency lgtm

[sadrul, 2016-03-31 21:06:57]

lgtm

It doesn't look like any of the targets actually list ui/base in its dependency
list. Maybe it can be removed from DEPS too?

[ccameron, 2016-03-31 22:20:24]

On 2016/03/31 20:17:21, chromium-reviews wrote:
> There is a new DEPS reference in gpu/ipc/service. Does it look good to you?

Yes, that lgtm.

[Mark Dittmer, 2016-04-01 12:04:03]

Add Mac dep on CoreMedia in gyp case

[Mark Dittmer, 2016-04-01 13:52:06]

rebase

[Mark Dittmer, 2016-04-01 13:53:14]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-04-01 13:53:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, piman@chromium.org, rjkroege@chromium.org,
sadrul@chromium.org, ccameron@chromium.org, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1845563005/#ps220001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-01 13:53:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/220001

[commit-bot: I haz the power, 2016-04-01 14:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 14:31:55]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Mark Dittmer, 2016-04-01 18:09:28]

Add skia dep for mac

[Mark Dittmer, 2016-04-01 18:41:15]

Use non-third-party skia gyp dep (for mac)

[Mark Dittmer, 2016-04-01 20:19:41]

Dep on skia, not skia_library

[Mark Dittmer, 2016-04-01 20:19:50]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-04-01 20:19:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, dpranke@chromium.org, sadrul@chromium.org,
ccameron@chromium.org, piman@chromium.org, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1845563005/#ps280001
(title: "Dep on skia, not skia_library")

[commit-bot: I haz the power, 2016-04-01 20:20:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/280001

[commit-bot: I haz the power, 2016-04-01 22:20:29]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-01 22:20:32]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2016-04-01 22:21:47]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}
==========

[commit-bot: I haz the power, 2016-04-01 22:21:49]

Patchset 15 (id:??) landed as
https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}

[Łukasz Anforowicz, 2016-04-01 23:03:21]

A revert of this CL (patchset #15 id:280001) has been created in
https://codereview.chromium.org/1846253003/ by lukasza@chromium.org.

The reason for reverting is: Speculating that this CL might be responsible for
closing the tree broken here:
https://build.chromium.org/p/chromium/builders/Win/builds/41941.

[Mark Dittmer, 2016-04-03 01:01:31]

Fix deps for Mac and Windows

[Mark Dittmer, 2016-04-03 01:02:27]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}
==========

[Mark Dittmer, 2016-04-04 14:55:33]

Fix source_set deps in the hopes of fixing Windows builds

[Mark Dittmer, 2016-04-04 17:35:57]

rebase

[Mark Dittmer, 2016-04-04 18:06:02]

Make gpu source deps private in gpu/ipc/service

[Mark Dittmer, 2016-04-04 19:34:11]

Add private gn deps for test_support

[Mark Dittmer, 2016-04-04 20:39:53]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 20:40:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/350133
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/350133

[commit-bot: I haz the power, 2016-04-04 20:47:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 20:47:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-04-04 21:00:18]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 21:00:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/350133
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/350133

[commit-bot: I haz the power, 2016-04-04 21:09:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 21:09:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-04-04 21:23:08]

rebase

[Mark Dittmer, 2016-04-04 21:26:57]

rebase fix

[Mark Dittmer, 2016-04-04 21:42:52]

Attempt: Remove dep on other CL

[Mark Dittmer, 2016-04-04 21:46:13]

Attempt: Remove dep on other CL (again)

[Mark Dittmer, 2016-04-04 21:46:37]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-04 21:47:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/450001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/450001

[commit-bot: I haz the power, 2016-04-04 23:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 23:57:01]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-04-05 18:56:32]

Make gpu/ipc/service:test_support dep on :service not :ipc_service_sources

[Mark Dittmer, 2016-04-05 20:24:02]

Privatize gpu/command_buffer/service dep on
gpu/command_buffer/common:common_sources

[Mark Dittmer, 2016-04-05 20:25:10]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-05 20:25:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/490001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/490001

[commit-bot: I haz the power, 2016-04-05 20:32:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 20:32:11]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbroman, 2016-04-05 22:03:38]

https://codereview.chromium.org/1845563005/diff/490001/gpu/ipc/service/BUILD.gn
File gpu/ipc/service/BUILD.gn (right):

https://codereview.chromium.org/1845563005/diff/490001/gpu/ipc/service/BUILD....
gpu/ipc/service/BUILD.gn:126: "//gpu/ipc/common:ipc_common_sources",
shouldn't this be //gpu/ipc/common?

[Mark Dittmer, 2016-04-06 00:00:52]

Revert bad deps change

[Mark Dittmer, 2016-04-06 00:02:20]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 00:02:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/510001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/510001

[Mark Dittmer, 2016-04-06 00:51:53]

Fixed up sourc_set dep.

https://codereview.chromium.org/1845563005/diff/490001/gpu/ipc/service/BUILD.gn
File gpu/ipc/service/BUILD.gn (right):

https://codereview.chromium.org/1845563005/diff/490001/gpu/ipc/service/BUILD....
gpu/ipc/service/BUILD.gn:126: "//gpu/ipc/common:ipc_common_sources",
On 2016/04/05 22:03:37, jbroman wrote:
> shouldn't this be //gpu/ipc/common?

Yes.

[Mark Dittmer, 2016-04-06 00:53:35]

Drop source_set dep from :test_support

[brettw, 2016-04-06 01:26:23]

brettw@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2016-04-06 01:26:27]

https://codereview.chromium.org/1845563005/diff/530001/gpu/ipc/service/BUILD.gn
File gpu/ipc/service/BUILD.gn (right):

https://codereview.chromium.org/1845563005/diff/530001/gpu/ipc/service/BUILD....
gpu/ipc/service/BUILD.gn:123: "//testing/gtest:gtest",
Remove ":gtest" suffix, it's redundant.

https://codereview.chromium.org/1845563005/diff/530001/gpu/ipc/service/BUILD....
gpu/ipc/service/BUILD.gn:130: test("gpu_ipc_service_unittests") {
Are you sure you want to add a completely new test binary? This will not run on
the bots without a bunch of configuration. I would normally make this a
"gpu_ipc_service_tests" source set and link it from the toplevel gpu_unittests.

https://codereview.chromium.org/1845563005/diff/530001/gpu/ipc/service/BUILD....
gpu/ipc/service/BUILD.gn:131: configs += [ "//build/config:precompiled_headers"
]
Don't use precompiled headers for 4 source files, it will be slower. See the
definition of this config for more advice.

[Fady Samuel, 2016-04-06 09:38:46]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 09:39:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/530001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/530001

[commit-bot: I haz the power, 2016-04-06 09:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 09:42:26]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Mark Dittmer, 2016-04-06 12:08:03]

rebase

[Mark Dittmer, 2016-04-06 12:09:10]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 12:09:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/550001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/550001

[commit-bot: I haz the power, 2016-04-06 12:20:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 12:20:55]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[Mark Dittmer, 2016-04-06 12:30:48]

Fix up gpu:: qualification after rebase

[Mark Dittmer, 2016-04-06 12:33:48]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 12:34:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/570001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/570001

[commit-bot: I haz the power, 2016-04-06 12:45:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 12:45:39]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Mark Dittmer, 2016-04-06 14:19:30]

Fix up gpu:: qualification after rebase

[Mark Dittmer, 2016-04-06 14:22:48]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 14:23:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/590001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/590001

[commit-bot: I haz the power, 2016-04-06 14:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 14:35:31]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Mark Dittmer, 2016-04-06 15:11:24]

Fix up gpu:: qualification after rebase

[Mark Dittmer, 2016-04-06 15:18:22]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 15:18:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/610001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/610001

[commit-bot: I haz the power, 2016-04-06 16:24:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 16:24:16]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-04-06 17:01:06]

Add unittests dep on content

[Mark Dittmer, 2016-04-06 17:26:00]

Revert dep on content (trying to fix the wrong unittest)

[Mark Dittmer, 2016-04-06 17:40:55]

Add content_common as dep for video_decode_accelerator_unittest in both gyp and
gn

[Mark Dittmer, 2016-04-06 17:43:40]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 17:44:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/670001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/670001

[commit-bot: I haz the power, 2016-04-06 18:52:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:52:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mark Dittmer, 2016-04-06 20:41:04]

Export GetContentClient to appease the gods of the Android build

[Mark Dittmer, 2016-04-06 20:44:13]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 20:44:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/690001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/690001

[Mark Dittmer, 2016-04-06 20:47:57]

piman@, PTAL: Small change to content/public/common exports to fix Android build
failure.

https://codereview.chromium.org/1845563005/diff/690001/content/public/common/...
File content/public/common/content_client.h (right):

https://codereview.chromium.org/1845563005/diff/690001/content/public/common/...
content/public/common/content_client.h:56: CONTENT_EXPORT ContentClient*
GetContentClient();
This was necessary to fix this Android build failure:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...

[commit-bot: I haz the power, 2016-04-06 22:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 22:24:10]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mark Dittmer, 2016-04-07 15:28:19]

Rebase, then drop unnnecesary content_common dep, add missing CONTENT_EXPORT,
and add gpu_command_buffer_service dep to get gyp builds of
video_decode_accelerator_unittest working again

[Mark Dittmer, 2016-04-07 15:30:55]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 15:31:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/710001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/710001

[commit-bot: I haz the power, 2016-04-07 15:34:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 15:34:52]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Dittmer, 2016-04-07 17:30:51]

rebase

[Mark Dittmer, 2016-04-07 17:51:59]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 17:52:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/730001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/730001

[commit-bot: I haz the power, 2016-04-07 21:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:11:51]

Dry run: This issue passed the CQ dry run.

[piman, 2016-04-07 22:26:58]

https://codereview.chromium.org/1845563005/diff/730001/content/common/gpu/med...
File content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.h
(right):

https://codereview.chromium.org/1845563005/diff/730001/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.h:39: #endif
Please just add CONTENT_EXPORT unconditionally (just remove the #if defined)

https://codereview.chromium.org/1845563005/diff/730001/content/public/common/...
File content/public/common/content_client.h (right):

https://codereview.chromium.org/1845563005/diff/730001/content/public/common/...
content/public/common/content_client.h:56: CONTENT_EXPORT ContentClient*
GetContentClient();
Please remove this change.

[Mark Dittmer, 2016-04-08 13:08:24]

Address comments from piman@

[Mark Dittmer, 2016-04-08 13:08:44]

Addressed comments from piman@

https://codereview.chromium.org/1845563005/diff/730001/content/common/gpu/med...
File content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.h
(right):

https://codereview.chromium.org/1845563005/diff/730001/content/common/gpu/med...
content/common/gpu/media/gpu_video_decode_accelerator_factory_impl.h:39: #endif
On 2016/04/07 22:26:58, piman wrote:
> Please just add CONTENT_EXPORT unconditionally (just remove the #if defined)

Done.

https://codereview.chromium.org/1845563005/diff/730001/content/public/common/...
File content/public/common/content_client.h (right):

https://codereview.chromium.org/1845563005/diff/730001/content/public/common/...
content/public/common/content_client.h:56: CONTENT_EXPORT ContentClient*
GetContentClient();
On 2016/04/07 22:26:58, piman wrote:
> Please remove this change.

Done.

[Mark Dittmer, 2016-04-08 13:40:31]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-04-08 13:40:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, dpranke@chromium.org, sadrul@chromium.org,
ccameron@chromium.org, piman@chromium.org, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1845563005/#ps740001
(title: "Address comments from piman@")

[commit-bot: I haz the power, 2016-04-08 13:40:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/740001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/740001

[commit-bot: I haz the power, 2016-04-08 13:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 13:49:48]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Mark Dittmer, 2016-04-08 14:27:52]

Drop ref to deleted content_tests_gypi_values.content_unittests_ozone_sources

[Mark Dittmer, 2016-04-08 14:28:16]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-04-08 14:28:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, dpranke@chromium.org, sadrul@chromium.org,
ccameron@chromium.org, piman@chromium.org, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1845563005/#ps760001
(title: "Drop ref to deleted
content_tests_gypi_values.content_unittests_ozone_sources")

[commit-bot: I haz the power, 2016-04-08 14:28:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845563005/760001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845563005/760001

[commit-bot: I haz the power, 2016-04-08 15:28:59]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}
==========

[commit-bot: I haz the power, 2016-04-08 15:29:02]

Committed patchset #40 (id:760001)

[commit-bot: I haz the power, 2016-04-08 15:30:22]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}

Committed: https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
Cr-Commit-Position: refs/heads/master@{#386084}
==========

[commit-bot: I haz the power, 2016-04-08 15:30:26]

Patchset 40 (id:??) landed as
https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
Cr-Commit-Position: refs/heads/master@{#386084}

[tommi (sloooow) - chröme, 2016-07-27 21:59:36]

On 2016/04/08 15:30:26, commit-bot: I haz the power wrote:
> Patchset 40 (id:??) landed as
> https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
> Cr-Commit-Position: refs/heads/master@{#386084}

Is there a chance that this CL could have caused performance regressions on
CrOS?

[tommi (sloooow) - chröme, 2016-07-27 22:00:38]

Description was changed from

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}

Committed: https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
Cr-Commit-Position: refs/heads/master@{#386084}
==========

to

==========
Refactor content/common/gpu into gpu/ipc/service. This is a part of a larger
refactor for Mus (see label:gpurefactor).

BUG=586385
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/721be995e023023793e547c28e0f6f7843bdbd99
Cr-Commit-Position: refs/heads/master@{#384705}

Committed: https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
Cr-Commit-Position: refs/heads/master@{#386084}
==========

[Fady Samuel, 2016-07-27 22:02:23]

On 2016/07/27 21:59:36, tommi-chrömium wrote:
> On 2016/04/08 15:30:26, commit-bot: I haz the power wrote:
> > Patchset 40 (id:??) landed as
> > https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
> > Cr-Commit-Position: refs/heads/master@{#386084}
> 
> Is there a chance that this CL could have caused performance regressions on
> CrOS?

That seems highly unlikely I think. This is a pure move / refactor. This
shouldn't have changed any performance characteristics.

[tommi (sloooow) - chröme, 2016-07-27 22:06:56]

On 2016/07/27 22:02:23, Fady Samuel wrote:
> On 2016/07/27 21:59:36, tommi-chrömium wrote:
> > On 2016/04/08 15:30:26, commit-bot: I haz the power wrote:
> > > Patchset 40 (id:??) landed as
> > > https://crrev.com/d88b8358c712374a258672eaa373f0ad415e3c4e
> > > Cr-Commit-Position: refs/heads/master@{#386084}
> > 
> > Is there a chance that this CL could have caused performance regressions on
> > CrOS?
> 
> That seems highly unlikely I think. This is a pure move / refactor. This
> shouldn't have changed any performance characteristics.

Thanks.  We're looking through a large list of CLs to track down perf issues
that seem to be specific to CrOS.  This CL is huge, so thanks for helping with
the due diligence.