detach -> release

detach -> release

The C++ standard library uses the name "release" for the operation we call "detach".

Rewriting each "detach(" to "release(" brings us a step closer to using standard library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).

This was a fairly blind transformation.  There may have been unintentional conversions in here, but it's probably for the best to have everything uniformly say "release".

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1809733002

Committed: https://skia.googlesource.com/skia/+/18300a3aa7cb6eb55d21bb0450dffa58b6fc062c

[mtklein_C, 2016-03-16 17:53:54]

Description was changed from

==========
detach -> release

BUG=skia:
==========

to

==========
detach -> release

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-03-16 17:58:19]

Description was changed from

==========
detach -> release

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
detach -> release

The C++ standard library uses the name "release" for the operation we call
"detach".

Rewriting each "detach(" to "release(" brings us a step closer to using standard
library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).

This was a fairly blind transformation.  There may have been unintentional
conversions in here, but it's probably for the best to have everything uniformly
say "release".

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-03-16 18:00:50]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 18:00:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809733002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809733002/1

[commit-bot: I haz the power, 2016-03-16 18:03:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 18:03:27]

Dry run: Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein_C, 2016-03-16 18:07:55]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-16 18:08:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809733002/20001

[mtklein_C, 2016-03-16 18:25:01]

The CQ bit was unchecked by mtklein@chromium.org

[mtklein_C, 2016-03-16 20:30:12]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[reed1, 2016-03-16 20:50:35]

lgtm

[mtklein, 2016-03-16 20:51:54]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-03-16 20:51:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1809733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1809733002/20001

[commit-bot: I haz the power, 2016-03-16 20:53:39]

Description was changed from

==========
detach -> release

The C++ standard library uses the name "release" for the operation we call
"detach".

Rewriting each "detach(" to "release(" brings us a step closer to using standard
library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).

This was a fairly blind transformation.  There may have been unintentional
conversions in here, but it's probably for the best to have everything uniformly
say "release".

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
detach -> release

The C++ standard library uses the name "release" for the operation we call
"detach".

Rewriting each "detach(" to "release(" brings us a step closer to using standard
library types directly (e.g. std::unique_ptr instead of SkAutoTDelete).

This was a fairly blind transformation.  There may have been unintentional
conversions in here, but it's probably for the best to have everything uniformly
say "release".

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/18300a3aa7cb6eb55d21bb0450dffa58b6fc062c
==========

[commit-bot: I haz the power, 2016-03-16 20:53:40]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/18300a3aa7cb6eb55d21bb0450dffa58b6fc062c