src/xps/SkXPSDevice.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/xps/SkXPSDevice.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/xps/SkXPSDevice.cpp

diff --git a/src/xps/SkXPSDevice.cpp b/src/xps/SkXPSDevice.cpp

index e4ac2aa74229bca7f52abe170a498bf05270f105..5d12c499ed2891230cce75c7c318e1f2f464595a 100644

--- a/src/xps/SkXPSDevice.cpp

+++ b/src/xps/SkXPSDevice.cpp

@@ -420,10 +420,10 @@ static HRESULT subset_typeface(SkXPSDevice::TypefaceUse* current) {

}

SkAutoTDelete<SkMemoryStream> newStream(new SkMemoryStream());

- newStream->setMemoryOwned(fontPackageBuffer.detach(), bytesWritten + extra);

+ newStream->setMemoryOwned(fontPackageBuffer.release(), bytesWritten + extra);

SkTScopedComPtr<IStream> newIStream;

- SkIStream::CreateFromSkStream(newStream.detach(), true, &newIStream);

+ SkIStream::CreateFromSkStream(newStream.release(), true, &newIStream);

XPS_FONT_EMBEDDING embedding;

HRM(current->xpsFont->GetEmbeddingOption(&embedding),

« no previous file with comments | « src/xps/SkDocument_XPS.cpp ('k') | tests/BadIcoTest.cpp » ('j') | no next file with comments »