src/pdf/SkPDFStream.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFStream.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFStream.cpp

diff --git a/src/pdf/SkPDFStream.cpp b/src/pdf/SkPDFStream.cpp

index b8f2e4e92b896d656e9a63d50ae7e8574f99ea1f..8b8f323db6c311a7708504cf68f610cc3f95ccba 100644

--- a/src/pdf/SkPDFStream.cpp

+++ b/src/pdf/SkPDFStream.cpp

@@ -45,7 +45,7 @@ void SkPDFStream::setData(SkStream* stream) {

if (dup && dup->hasLength() &&

dup->getLength() <= length + strlen("/Filter_/FlateDecode_")) {

this->insertInt("Length", dup->getLength());

- fCompressedData.reset(dup.detach());

+ fCompressedData.reset(dup.release());

return;

}

« no previous file with comments | « src/pdf/SkPDFShader.cpp ('k') | src/ports/SkFontHost_mac.cpp » ('j') | no next file with comments »