samplecode/SamplePictFile.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SamplePictFile.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SamplePictFile.cpp

diff --git a/samplecode/SamplePictFile.cpp b/samplecode/SamplePictFile.cpp

index 43e7cf49e546cefcbe8d2d4dc915835aab8d236c..9203cbad7778fa2610a70d1958dde7dd33e2e8f4 100644

--- a/samplecode/SamplePictFile.cpp

+++ b/samplecode/SamplePictFile.cpp

@@ -191,7 +191,7 @@ private:

switch (bbox) {

case kNo_BBoxType:

// no bbox playback necessary

- return pic.detach();

+ return pic.release();

case kRTree_BBoxType:

factory.reset(new SkRTreeFactory);

break;

« no previous file with comments | « samplecode/SampleApp.cpp ('k') | src/android/SkBitmapRegionDecoder.cpp » ('j') | no next file with comments »