platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp ('k') | samplecode/SampleApp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp

diff --git a/platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp b/platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp

index 76ace6df4661fbed7ac8620fd1f9f6f0404251e3..644191d3d745381071f682a7f59ba9092c7841a5 100644

--- a/platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp

+++ b/platform_tools/android/apps/visualbench/src/main/jni/SkOSWindow_AndroidNative.cpp

@@ -18,7 +18,7 @@ SkOSWindow::SkOSWindow(void* hwnd) {

}

SkOSWindow::~SkOSWindow() {

- this->detach();

+ this->release();

}

bool SkOSWindow::attach(SkBackEndTypes attachType,

@@ -149,7 +149,7 @@ bool SkOSWindow::attach(SkBackEndTypes attachType,

}

-void SkOSWindow::detach() {

+void SkOSWindow::release() {

if (fWindow.fDisplay != EGL_NO_DISPLAY) {

eglMakeCurrent(fWindow.fDisplay, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);

if (fWindow.fContext != EGL_NO_CONTEXT) {

« no previous file with comments | « platform_tools/android/apps/sample_app/src/main/jni/com_skia_SkiaSampleRenderer.cpp ('k') | samplecode/SampleApp.cpp » ('j') | no next file with comments »