Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: src/effects/gradients/SkGradientBitmapCache.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: (C) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/effects/gradients/SkGradientBitmapCache.h ('k') | src/fonts/SkFontMgr_fontconfig.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2010 Google Inc. 3 * Copyright 2010 Google Inc.
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 8
9 9
10 #include "SkGradientBitmapCache.h" 10 #include "SkGradientBitmapCache.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 this->validate(); 44 this->validate();
45 45
46 Entry* entry = fHead; 46 Entry* entry = fHead;
47 while (entry) { 47 while (entry) {
48 Entry* next = entry->fNext; 48 Entry* next = entry->fNext;
49 delete entry; 49 delete entry;
50 entry = next; 50 entry = next;
51 } 51 }
52 } 52 }
53 53
54 SkGradientBitmapCache::Entry* SkGradientBitmapCache::detach(Entry* entry) const { 54 SkGradientBitmapCache::Entry* SkGradientBitmapCache::release(Entry* entry) const {
55 if (entry->fPrev) { 55 if (entry->fPrev) {
56 SkASSERT(fHead != entry); 56 SkASSERT(fHead != entry);
57 entry->fPrev->fNext = entry->fNext; 57 entry->fPrev->fNext = entry->fNext;
58 } else { 58 } else {
59 SkASSERT(fHead == entry); 59 SkASSERT(fHead == entry);
60 fHead = entry->fNext; 60 fHead = entry->fNext;
61 } 61 }
62 if (entry->fNext) { 62 if (entry->fNext) {
63 SkASSERT(fTail != entry); 63 SkASSERT(fTail != entry);
64 entry->fNext->fPrev = entry->fPrev; 64 entry->fNext->fPrev = entry->fPrev;
(...skipping 18 matching lines...) Expand all
83 bool SkGradientBitmapCache::find(const void* buffer, size_t size, SkBitmap* bm) const { 83 bool SkGradientBitmapCache::find(const void* buffer, size_t size, SkBitmap* bm) const {
84 AutoValidate av(this); 84 AutoValidate av(this);
85 85
86 Entry* entry = fHead; 86 Entry* entry = fHead;
87 while (entry) { 87 while (entry) {
88 if (entry->equals(buffer, size)) { 88 if (entry->equals(buffer, size)) {
89 if (bm) { 89 if (bm) {
90 *bm = entry->fBitmap; 90 *bm = entry->fBitmap;
91 } 91 }
92 // move to the head of our list, so we purge it last 92 // move to the head of our list, so we purge it last
93 this->detach(entry); 93 this->release(entry);
94 this->attachToHead(entry); 94 this->attachToHead(entry);
95 return true; 95 return true;
96 } 96 }
97 entry = entry->fNext; 97 entry = entry->fNext;
98 } 98 }
99 return false; 99 return false;
100 } 100 }
101 101
102 void SkGradientBitmapCache::add(const void* buffer, size_t len, const SkBitmap& bm) { 102 void SkGradientBitmapCache::add(const void* buffer, size_t len, const SkBitmap& bm) {
103 AutoValidate av(this); 103 AutoValidate av(this);
104 104
105 if (fEntryCount == fMaxEntries) { 105 if (fEntryCount == fMaxEntries) {
106 SkASSERT(fTail); 106 SkASSERT(fTail);
107 delete this->detach(fTail); 107 delete this->release(fTail);
108 fEntryCount -= 1; 108 fEntryCount -= 1;
109 } 109 }
110 110
111 Entry* entry = new Entry(buffer, len, bm); 111 Entry* entry = new Entry(buffer, len, bm);
112 this->attachToHead(entry); 112 this->attachToHead(entry);
113 fEntryCount += 1; 113 fEntryCount += 1;
114 } 114 }
115 115
116 /////////////////////////////////////////////////////////////////////////////// 116 ///////////////////////////////////////////////////////////////////////////////
117 117
(...skipping 26 matching lines...) Expand all
144 entry = entry->fPrev; 144 entry = entry->fPrev;
145 } 145 }
146 SkASSERT(0 == count); 146 SkASSERT(0 == count);
147 } else { 147 } else {
148 SkASSERT(nullptr == fHead); 148 SkASSERT(nullptr == fHead);
149 SkASSERT(nullptr == fTail); 149 SkASSERT(nullptr == fTail);
150 } 150 }
151 } 151 }
152 152
153 #endif 153 #endif
OLDNEW
« no previous file with comments | « src/effects/gradients/SkGradientBitmapCache.h ('k') | src/fonts/SkFontMgr_fontconfig.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698