Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: src/views/sdl/SkOSWindow_SDL.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: (C) Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/views/mac/SkOSWindow_Mac.mm ('k') | src/views/unix/SkOSWindow_Unix.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/views/sdl/SkOSWindow_SDL.cpp
diff --git a/src/views/sdl/SkOSWindow_SDL.cpp b/src/views/sdl/SkOSWindow_SDL.cpp
index c39a4fdfef8a64cc4453f8df0b739b7cee5ae047..76d43498e8ff7f3c79fe0248a532e51df52350a6 100644
--- a/src/views/sdl/SkOSWindow_SDL.cpp
+++ b/src/views/sdl/SkOSWindow_SDL.cpp
@@ -50,7 +50,7 @@ SkOSWindow* SkOSWindow::GetInstanceForWindowID(Uint32 windowID) {
return nullptr;
}
-void SkOSWindow::detach() {
+void SkOSWindow::release() {
if (fGLContext) {
SDL_GL_DeleteContext(fGLContext);
fGLContext = nullptr;
@@ -76,7 +76,7 @@ bool SkOSWindow::attach(SkBackEndTypes attachType, int msaaSampleCount, Attachme
if (SDL_GL_MakeCurrent(fWindow, fGLContext) != 0) {
report_sdl_error("Failed to make SDL GL context current.");
- this->detach();
+ this->release();
return false;
}
@@ -219,7 +219,7 @@ void SkOSWindow::createWindow(int msaaSampleCount) {
}
void SkOSWindow::destroyWindow() {
- this->detach();
+ this->release();
if (fWindow) {
SDL_DestroyWindow(fWindow);
fWindow = nullptr;
« no previous file with comments | « src/views/mac/SkOSWindow_Mac.mm ('k') | src/views/unix/SkOSWindow_Unix.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698