tests/CachedDecodingPixelRefTest.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/CachedDecodingPixelRefTest.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/CachedDecodingPixelRefTest.cpp

diff --git a/tests/CachedDecodingPixelRefTest.cpp b/tests/CachedDecodingPixelRefTest.cpp

index a0d71bbd70df41bd0741f408c5e54d06d751f937..fe6b412cd1e6aab2aca93a85f8c948c370512db3 100644

--- a/tests/CachedDecodingPixelRefTest.cpp

+++ b/tests/CachedDecodingPixelRefTest.cpp

@@ -255,7 +255,7 @@ static void check_pixelref(TestImageGenerator::TestType type,

SkAutoTDelete<SkImageGenerator> gen(new TestImageGenerator(type, reporter, colorType));

REPORTER_ASSERT(reporter, gen.get() != nullptr);

SkBitmap lazy;

- bool success = SkDEPRECATED_InstallDiscardablePixelRef(gen.detach(), nullptr, &lazy, factory);

+ bool success = SkDEPRECATED_InstallDiscardablePixelRef(gen.release(), nullptr, &lazy, factory);

REPORTER_ASSERT(reporter, success);

if (TestImageGenerator::kSucceedGetPixels_TestType == type) {

« no previous file with comments | « tests/BadIcoTest.cpp ('k') | tests/CodexTest.cpp » ('j') | no next file with comments »