src/core/SkTextBlob.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkTextBlob.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkTextBlob.cpp

diff --git a/src/core/SkTextBlob.cpp b/src/core/SkTextBlob.cpp

index 7f6536cc8adb8b48d0f7a204b52d4b1b0db116ff..79fe858aacf0fd8f0cb8929edeee51ed16230f50 100644

--- a/src/core/SkTextBlob.cpp

+++ b/src/core/SkTextBlob.cpp

@@ -624,7 +624,7 @@ const SkTextBlob* SkTextBlobBuilder::build() {

fStorage.realloc(fStorageUsed);

}

- const SkTextBlob* blob = new (fStorage.detach()) SkTextBlob(fRunCount, fBounds);

+ const SkTextBlob* blob = new (fStorage.release()) SkTextBlob(fRunCount, fBounds);

SkDEBUGCODE(const_cast<SkTextBlob*>(blob)->fStorageSize = fStorageSize;)

SkDEBUGCODE(

« no previous file with comments | « src/core/SkStream.cpp ('k') | src/core/SkTypeface.cpp » ('j') | no next file with comments »