tests/BadIcoTest.cpp - Issue 1809733002: detach -> release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/BadIcoTest.cpp

Issue 1809733002: detach -> release (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: (C) Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/BadIcoTest.cpp

diff --git a/tests/BadIcoTest.cpp b/tests/BadIcoTest.cpp

index c387e157be21fdb982eb26cc2b66a09f1b065f03..5c01490f9b0884a149fcfa93f8844eecda637d7f 100644

--- a/tests/BadIcoTest.cpp

+++ b/tests/BadIcoTest.cpp

@@ -31,7 +31,7 @@ DEF_TEST(BadImage, reporter) {

for (size_t i = 0; i < SK_ARRAY_COUNT(badImages); ++i) {

SkString fullPath = SkOSPath::Join(resourcePath.c_str(), badImages[i]);

SkAutoTDelete<SkStream> stream(SkStream::NewFromFile(fullPath.c_str()));

- SkAutoTDelete<SkCodec> codec(SkCodec::NewFromStream(stream.detach()));

+ SkAutoTDelete<SkCodec> codec(SkCodec::NewFromStream(stream.release()));

// These images are corrupt. It's not important whether we succeed/fail in codec

// creation or decoding. We just want to make sure that we don't crash.

« no previous file with comments | « src/xps/SkXPSDevice.cpp ('k') | tests/CachedDecodingPixelRefTest.cpp » ('j') | no next file with comments »