partial switch over to sp usage of shaders

partial switch over to sp usage of shaders

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1776973003

Committed: https://skia.googlesource.com/skia/+/2ad1aa67c6894696cdd65ec56057f81031d1c24a

[reed1, 2016-03-09 15:02:44]

Description was changed from

==========
partial switch over to sp useage of shaders

BUG=skia:
==========

to

==========
partial switch over to sp useage of shaders

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-03-09 15:03:05]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-09 15:03:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776973003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776973003/1

[reed1, 2016-03-09 15:09:39]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-03-09 15:09:39]

we might try converting chrome/blink over on gradients, now that the "Makers"
have already landed...

[reed1, 2016-03-09 15:10:10]

Description was changed from

==========
partial switch over to sp useage of shaders

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
partial switch over to sp usage of shaders

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[commit-bot: I haz the power, 2016-03-09 15:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-09 15:20:07]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-03-09 15:23:07]

lgtm

https://codereview.chromium.org/1776973003/diff/1/src/utils/SkLua.cpp
File src/utils/SkLua.cpp (right):

https://codereview.chromium.org/1776973003/diff/1/src/utils/SkLua.cpp#newcode...
src/utils/SkLua.cpp:1990: push_ref(L, s);
nit: can prolly move s here.

[reed1, 2016-03-09 15:55:34]

On 2016/03/09 15:23:07, f(malita) wrote:
> lgtm
> 
> https://codereview.chromium.org/1776973003/diff/1/src/utils/SkLua.cpp
> File src/utils/SkLua.cpp (right):
> 
>
https://codereview.chromium.org/1776973003/diff/1/src/utils/SkLua.cpp#newcode...
> src/utils/SkLua.cpp:1990: push_ref(L, s);
> nit: can prolly move s here.

good catch (again). I need to really internalize that pattern.

[reed1, 2016-03-09 15:56:12]

The CQ bit was checked by reed@google.com

[reed1, 2016-03-09 15:56:13]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1776973003/#ps20001
(title: "move into lua container")

[commit-bot: I haz the power, 2016-03-09 15:56:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776973003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776973003/20001

[commit-bot: I haz the power, 2016-03-09 17:50:53]

Description was changed from

==========
partial switch over to sp usage of shaders

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
partial switch over to sp usage of shaders

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2ad1aa67c6894696cdd65ec56057f81031d1c24a
==========

[commit-bot: I haz the power, 2016-03-09 17:50:54]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2ad1aa67c6894696cdd65ec56057f81031d1c24a