Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed)

Created:
4 years, 10 months ago by martijnc
Modified:
4 years, 10 months ago
CC:
anandc+watch-blimp_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dtrainor+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, pfeldman, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make IPAddress::FromIPLiteral a member function. BUG=496258 TBR=dtrainor@chromium.org Committed: https://crrev.com/654c8c4f04b92dea31eeb07ec370c96d6b09a121 Cr-Commit-Position: refs/heads/master@{#374744}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -68 lines) Patch
M blimp/client/session/assignment_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/cast_device_provider_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/local_discovery/endpoint_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/base/ip_address.h View 1 chunk +3 lines, -3 lines 0 comments Download
M net/base/ip_address.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/base/ip_address_unittest.cc View 4 chunks +34 lines, -35 lines 2 comments Download
M net/base/ip_endpoint_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_transaction_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/server_socket.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
martijnc
Can you take a look? I just made the existing function a non-static one and ...
4 years, 10 months ago (2016-02-07 20:18:54 UTC) #8
eroman
lgtm https://codereview.chromium.org/1676023002/diff/100001/net/base/ip_address_unittest.cc File net/base/ip_address_unittest.cc (right): https://codereview.chromium.org/1676023002/diff/100001/net/base/ip_address_unittest.cc#newcode133 net/base/ip_address_unittest.cc:133: EXPECT_TRUE(ipv6_address.AssignFromIPLiteral("::1")); On 2016/02/07 20:18:54, martijnc wrote: > I ...
4 years, 10 months ago (2016-02-08 20:38:23 UTC) #9
martijnc
Thank you. +thakis for chrome/browser/* +dtrainer for blimp/client/session/assignment_source.cc Can you take a look?
4 years, 10 months ago (2016-02-08 20:59:12 UTC) #11
Nico
lgtm
4 years, 10 months ago (2016-02-08 21:01:58 UTC) #12
martijnc
TBR'ing dtrainor for the blimp change.
4 years, 10 months ago (2016-02-10 19:01:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1676023002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1676023002/100001
4 years, 10 months ago (2016-02-10 19:04:25 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 10 months ago (2016-02-10 22:11:09 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:36 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/654c8c4f04b92dea31eeb07ec370c96d6b09a121
Cr-Commit-Position: refs/heads/master@{#374744}

Powered by Google App Engine
This is Rietveld 408576698