Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/ip_address_unittest.cc ('K') | « net/http/http_server_properties_manager.cc ('k') | net/http/http_transaction_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager_unittest.cc
diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc
index 8276352e59ebf10d606015b695d41975a432f9ef..3d6f6c77308b9d479cc267d8e3d8a0ace0a70b0e 100644
--- a/net/http/http_server_properties_manager_unittest.cc
+++ b/net/http/http_server_properties_manager_unittest.cc
@@ -821,7 +821,7 @@ TEST_P(HttpServerPropertiesManagerTest, SupportsQuic) {
EXPECT_FALSE(http_server_props_manager_->GetSupportsQuic(&address));
IPAddress actual_address;
- CHECK(IPAddress::FromIPLiteral("127.0.0.1", &actual_address));
+ CHECK(actual_address.AssignFromIPLiteral("127.0.0.1"));
http_server_props_manager_->SetSupportsQuic(true, actual_address);
// ExpectScheduleUpdatePrefsOnNetworkThread() should be called only once.
http_server_props_manager_->SetSupportsQuic(true, actual_address);
@@ -889,7 +889,7 @@ TEST_P(HttpServerPropertiesManagerTest, Clear) {
http_server_props_manager_->SetAlternativeService(
spdy_server_mail, alternative_service, 1.0, one_day_from_now_);
IPAddress actual_address;
- CHECK(IPAddress::FromIPLiteral("127.0.0.1", &actual_address));
+ CHECK(actual_address.AssignFromIPLiteral("127.0.0.1"));
http_server_props_manager_->SetSupportsQuic(true, actual_address);
ServerNetworkStats stats;
stats.srtt = base::TimeDelta::FromMicroseconds(10);
@@ -1079,7 +1079,7 @@ TEST_P(HttpServerPropertiesManagerTest, UpdateCacheWithPrefs) {
// Set SupportsQuic.
IPAddress actual_address;
- CHECK(IPAddress::FromIPLiteral("127.0.0.1", &actual_address));
+ CHECK(actual_address.AssignFromIPLiteral("127.0.0.1"));
http_server_props_manager_->SetSupportsQuic(true, actual_address);
// Update cache.
« net/base/ip_address_unittest.cc ('K') | « net/http/http_server_properties_manager.cc ('k') | net/http/http_transaction_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698