net/http/http_server_properties_impl_unittest.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_impl_unittest.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_server_properties_impl_unittest.cc

diff --git a/net/http/http_server_properties_impl_unittest.cc b/net/http/http_server_properties_impl_unittest.cc

index 5a5b3261bd35dfdc0db397424fac3275d7fa5930..73c5c39c35514fca445ac6783603ffa9c581f910 100644

--- a/net/http/http_server_properties_impl_unittest.cc

+++ b/net/http/http_server_properties_impl_unittest.cc

@@ -1271,7 +1271,7 @@ TEST_F(SupportsQuicServerPropertiesTest, Initialize) {

EXPECT_TRUE(address.empty());

// Check by initializing with a valid address.

- CHECK(IPAddress::FromIPLiteral("127.0.0.1", &initial_address));

+ CHECK(initial_address.AssignFromIPLiteral("127.0.0.1"));

impl_.InitializeSupportsQuic(&initial_address);

EXPECT_TRUE(impl_.GetSupportsQuic(&address));

@@ -1284,7 +1284,7 @@ TEST_F(SupportsQuicServerPropertiesTest, SetSupportsQuic) {

EXPECT_TRUE(address.empty());

IPAddress actual_address;

- CHECK(IPAddress::FromIPLiteral("127.0.0.1", &actual_address));

+ CHECK(actual_address.AssignFromIPLiteral("127.0.0.1"));

impl_.SetSupportsQuic(true, actual_address);

EXPECT_TRUE(impl_.GetSupportsQuic(&address));