Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: net/base/ip_address.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_address.cc
diff --git a/net/base/ip_address.cc b/net/base/ip_address.cc
index d36eef341745a10a33bd470ba538b600225501b2..f19f9273223c12142dd8c614ced43266da4e0eee 100644
--- a/net/base/ip_address.cc
+++ b/net/base/ip_address.cc
@@ -55,14 +55,12 @@ std::string IPAddress::ToString() const {
return IPAddressToString(ip_address_);
}
-// static
-bool IPAddress::FromIPLiteral(const base::StringPiece& ip_literal,
- IPAddress* ip_address) {
+bool IPAddress::AssignFromIPLiteral(const base::StringPiece& ip_literal) {
std::vector<uint8_t> number;
if (!ParseIPLiteralToNumber(ip_literal, &number))
return false;
- std::swap(number, ip_address->ip_address_);
+ std::swap(number, ip_address_);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698