net/base/ip_endpoint_unittest.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/ip_endpoint_unittest.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/ip_endpoint_unittest.cc

diff --git a/net/base/ip_endpoint_unittest.cc b/net/base/ip_endpoint_unittest.cc

index 12dff00ae82ac58e747c23b41fcc20532781b6f4..9f7c0f0b21b6c5222309d5666ce87750a90c6043 100644

--- a/net/base/ip_endpoint_unittest.cc

+++ b/net/base/ip_endpoint_unittest.cc

@@ -68,8 +68,8 @@ class IPEndPointTest : public PlatformTest {

void SetUp() override {

// This is where we populate the TestData.

for (int index = 0; index < test_count; ++index) {

- EXPECT_TRUE(IPAddress::FromIPLiteral(tests[index].host,

- &tests[index].ip_address));

+ EXPECT_TRUE(

+ tests[index].ip_address.AssignFromIPLiteral(tests[index].host));

}

};