chrome/browser/local_discovery/service_discovery_client_unittest.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_unittest.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm ('k') | chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc » ('j') | net/base/ip_address_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_unittest.cc

diff --git a/chrome/browser/local_discovery/service_discovery_client_unittest.cc b/chrome/browser/local_discovery/service_discovery_client_unittest.cc

index 447dfb4588e1089055dd832e585200f27f6d850a..f972518704032493fcff06255e89779f3cc0fea8 100644

--- a/chrome/browser/local_discovery/service_discovery_client_unittest.cc

+++ b/chrome/browser/local_discovery/service_discovery_client_unittest.cc

@@ -412,8 +412,7 @@ class ServiceResolverTest : public ServiceDiscoveryTest {

ServiceResolverTest() {

metadata_expected_.push_back("hello");

address_expected_ = net::HostPortPair("myhello.local", 8888);

- EXPECT_TRUE(

- net::IPAddress::FromIPLiteral("1.2.3.4", &ip_address_expected_));

+ EXPECT_TRUE(ip_address_expected_.AssignFromIPLiteral("1.2.3.4"));

}

~ServiceResolverTest() {