chrome/browser/local_discovery/endpoint_resolver.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/endpoint_resolver.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/local_discovery/endpoint_resolver.cc

diff --git a/chrome/browser/local_discovery/endpoint_resolver.cc b/chrome/browser/local_discovery/endpoint_resolver.cc

index 5f59989de51d49e3108eab457cafd14e6487affa..d0ffaa72cecb196d969aaa51fc904c8a10aa2f0c 100644

--- a/chrome/browser/local_discovery/endpoint_resolver.cc

+++ b/chrome/browser/local_discovery/endpoint_resolver.cc

@@ -42,7 +42,7 @@ void EndpointResolver::Start(const net::HostPortPair& address,

const ResultCallback& callback) {

#if defined(OS_MACOSX)

net::IPAddress ip_address;

- if (!net::IPAddress::FromIPLiteral(address.host(), &ip_address)) {

+ if (!ip_address.AssignFromIPLiteral(address.host())) {

NOTREACHED() << address.ToString();

// Unexpected, but could be a reason for crbug.com/513505

base::debug::DumpWithoutCrashing();