Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index b0ec563a09d6c4983ffb0e1d095255d3a703988c..f7402425d1d999717964d2e4f4dcb890a94132c2 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -12914,7 +12914,7 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPooling) {
};
IPAddress ip;
- ASSERT_TRUE(IPAddress::FromIPLiteral("127.0.0.1", &ip));
+ ASSERT_TRUE(ip.AssignFromIPLiteral("127.0.0.1"));
IPEndPoint peer_addr = IPEndPoint(ip, 443);
MockConnect connect(ASYNC, OK, peer_addr);
SequencedSocketData spdy_data(connect, spdy_reads, arraysize(spdy_reads),
@@ -13014,7 +13014,7 @@ TEST_P(HttpNetworkTransactionTest, UseIPConnectionPoolingAfterResolution) {
};
IPAddress ip;
- ASSERT_TRUE(IPAddress::FromIPLiteral("127.0.0.1", &ip));
+ ASSERT_TRUE(ip.AssignFromIPLiteral("127.0.0.1"));
IPEndPoint peer_addr = IPEndPoint(ip, 443);
MockConnect connect(ASYNC, OK, peer_addr);
SequencedSocketData spdy_data(connect, spdy_reads, arraysize(spdy_reads),
@@ -13145,7 +13145,7 @@ TEST_P(HttpNetworkTransactionTest,
};
IPAddress ip;
- ASSERT_TRUE(IPAddress::FromIPLiteral("127.0.0.1", &ip));
+ ASSERT_TRUE(ip.AssignFromIPLiteral("127.0.0.1"));
IPEndPoint peer_addr = IPEndPoint(ip, 443);
MockConnect connect(ASYNC, OK, peer_addr);
SequencedSocketData spdy_data(connect, spdy_reads, arraysize(spdy_reads),
@@ -13872,7 +13872,7 @@ TEST_P(HttpNetworkTransactionTest, DoNotUseSpdySessionIfCertDoesNotMatch) {
SequencedSocketData data1(reads1, arraysize(reads1), writes1,
arraysize(writes1));
IPAddress ip;
- ASSERT_TRUE(IPAddress::FromIPLiteral(ip_addr, &ip));
+ ASSERT_TRUE(ip.AssignFromIPLiteral(ip_addr));
IPEndPoint peer_addr = IPEndPoint(ip, 443);
MockConnect connect_data1(ASYNC, OK, peer_addr);
data1.set_connect_data(connect_data1);

Powered by Google App Engine
This is Rietveld 408576698