chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/local_discovery/endpoint_resolver.cc ('k') | chrome/browser/local_discovery/service_discovery_client_unittest.cc » ('j') | net/base/ip_address_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

diff --git a/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm b/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

index 282ab9a852537a73c96d6e8550717463334b534d..751b2665e5118748acd2e2c8f0065368a74a65c0 100644

--- a/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

+++ b/chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm

@@ -128,7 +128,7 @@ TEST_F(ServiceDiscoveryClientMacTest, ServiceResolver) {

const std::string kIp = "2001:4860:4860::8844";

const uint16_t kPort = 4321;

net::IPAddress ip_address;

- ASSERT_TRUE(net::IPAddress::FromIPLiteral(kIp, &ip_address));

+ ASSERT_TRUE(ip_address.AssignFromIPLiteral(kIp));

net::IPEndPoint endpoint(ip_address, kPort);

net::SockaddrStorage storage;

ASSERT_TRUE(endpoint.ToSockAddr(storage.addr, &storage.addr_len));