net/http/http_transaction_test_util.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_transaction_test_util.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_transaction_test_util.cc

diff --git a/net/http/http_transaction_test_util.cc b/net/http/http_transaction_test_util.cc

index df259de330a55a1a195e7179ab00d1602dad5a45..0e027a2ab2ff30d1f63b05d06fc11683728fea6c 100644

--- a/net/http/http_transaction_test_util.cc

+++ b/net/http/http_transaction_test_util.cc

@@ -391,7 +391,7 @@ bool MockNetworkTransaction::GetLoadTimingInfo(

bool MockNetworkTransaction::GetRemoteEndpoint(IPEndPoint* endpoint) const {

IPAddress ip_address;

- CHECK(IPAddress::FromIPLiteral("127.0.0.1", &ip_address));

+ CHECK(ip_address.AssignFromIPLiteral("127.0.0.1"));

*endpoint = IPEndPoint(ip_address, 80);

return true;

}