net/socket/server_socket.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/server_socket.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/server_socket.cc

diff --git a/net/socket/server_socket.cc b/net/socket/server_socket.cc

index 15a87c160225db0de1a8073f72a7b8d7cd0a407e..f2c2383ab585221b4c892c29dba230c8955e5de5 100644

--- a/net/socket/server_socket.cc

+++ b/net/socket/server_socket.cc

@@ -20,7 +20,7 @@ int ServerSocket::ListenWithAddressAndPort(const std::string& address_string,

uint16_t port,

int backlog) {

IPAddress ip_address;

- if (!IPAddress::FromIPLiteral(address_string, &ip_address)) {

+ if (!ip_address.AssignFromIPLiteral(address_string)) {

return ERR_ADDRESS_INVALID;

}