Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: net/base/ip_address.h

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ip_address.h
diff --git a/net/base/ip_address.h b/net/base/ip_address.h
index a2e368c56f9d41a40bbfe3ad1d478b4ecc87e868..ef5e684ad82224c5f828ef1512e3feb338838d72 100644
--- a/net/base/ip_address.h
+++ b/net/base/ip_address.h
@@ -74,9 +74,9 @@ class NET_EXPORT IPAddress {
std::string ToString() const;
// Parses an IP address literal (either IPv4 or IPv6) to its numeric value.
- // Returns true on success and fills |ip_address| with the numeric value.
- static bool FromIPLiteral(const base::StringPiece& ip_literal,
- IPAddress* ip_address) WARN_UNUSED_RESULT;
+ // Returns true on success and fills |ip_address_| with the numeric value.
+ bool AssignFromIPLiteral(const base::StringPiece& ip_literal)
+ WARN_UNUSED_RESULT;
// Returns the underlying byte vector.
const std::vector<uint8_t>& bytes() const { return ip_address_; };

Powered by Google App Engine
This is Rietveld 408576698